Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 2177533002: Revert of BubbleFrameView: add top padding even when close button is hidden (Closed)

Created:
4 years, 5 months ago by Elly Fong-Jones
Modified:
4 years, 5 months ago
Reviewers:
msw
CC:
chromium-reviews, tfarina, msw+watch_chromium.org, groby+bubble_chromium.org, hcarmona+bubble_chromium.org, rouslan+bubble_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of BubbleFrameView: add top padding even when close button is hidden (patchset #7 id:120001 of https://codereview.chromium.org/2148963002/ ) Reason for revert: Caused https://crbug.com/630539 Original issue's description: > BubbleFrameView: add top padding even when close button is hidden > > If there's no title or close button present, BubbleFrameView still needs some > top padding to avoid the content being hard up against the top edge. Always pad > as though the close button was visible, even if it's not, unless there's a > title. > > BUG=622859 > > Committed: https://crrev.com/f06ef4ac6ac3dd2f3a76486d2efde9ec35583ae6 > Cr-Commit-Position: refs/heads/master@{#406856} TBR=msw@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=622859 Committed: https://crrev.com/e8b6973cc757a5fe723fca9c3efb1ee540406abb Cr-Commit-Position: refs/heads/master@{#407161}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -25 lines) Patch
M chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_container.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/bubble/bubble_dialog_delegate_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/bubble/bubble_frame_view.h View 4 chunks +3 lines, -4 lines 0 comments Download
M ui/views/bubble/bubble_frame_view.cc View 2 chunks +6 lines, -8 lines 0 comments Download
M ui/views/bubble/bubble_frame_view_unittest.cc View 4 chunks +2 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Elly Fong-Jones
Created Revert of BubbleFrameView: add top padding even when close button is hidden
4 years, 5 months ago (2016-07-22 15:05:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2177533002/1
4 years, 5 months ago (2016-07-22 15:05:25 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 15:06:07 UTC) #4
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 15:08:17 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e8b6973cc757a5fe723fca9c3efb1ee540406abb
Cr-Commit-Position: refs/heads/master@{#407161}

Powered by Google App Engine
This is Rietveld 408576698