Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2177493002: Fix SW sRGB dst + LCD coverage bug. (Closed)

Created:
4 years, 5 months ago by mtklein_C
Modified:
4 years, 5 months ago
Reviewers:
reed1
CC:
reviews_skia.org, Brian Osman
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix SW sRGB dst + LCD coverage bug. We're using the linear procs for sRGB destintations and the sRGB procs for linear destinations. Fix that. C.f. State32::getLCDProc(), which flags |= kDstIsSRGB_LCDFlag. kDistIsSRGB is (1<<2) == 4, so the sRGB procs must be 4-7, not 0-3. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2177493002 Committed: https://skia.googlesource.com/skia/+/d01a8f470f43b50feb26cc73db89809e292feee2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/core/SkXfermode4f.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
mtklein_C
Another pre-flight bug fix to minimize the diffs for the raster pipeline blitter.
4 years, 5 months ago (2016-07-22 14:16:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2177493002/1
4 years, 5 months ago (2016-07-22 14:16:33 UTC) #5
reed1
doh! lgtm
4 years, 5 months ago (2016-07-22 14:23:23 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 14:35:11 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/d01a8f470f43b50feb26cc73db89809e292feee2

Powered by Google App Engine
This is Rietveld 408576698