src/compiler/mips/code-generator-mips.cc - Issue 2177483002: [turbofan] Handle impossible types (Type::None()) in the backend.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/mips/code-generator-mips.cc

Issue 2177483002: [turbofan] Handle impossible types (Type::None()) in the backend. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix?? Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/mips/code-generator-mips.cc

diff --git a/src/compiler/mips/code-generator-mips.cc b/src/compiler/mips/code-generator-mips.cc

index 09e54bf5f15727ed799430312f01b675bcd56b29..9ab997b724bf6662c8e71482de61bd75e8551397 100644

--- a/src/compiler/mips/code-generator-mips.cc

+++ b/src/compiler/mips/code-generator-mips.cc

@@ -693,6 +693,9 @@ CodeGenerator::CodeGenResult CodeGenerator::AssembleArchInstruction(

case kArchDebugBreak:

__ stop("kArchDebugBreak");

break;

+ case kArchImpossible:

+ __ Abort(kConversionFromImpossibleValue);

+ break;

case kArchComment: {

Address comment_string = i.InputExternalReference(0).address();

__ RecordComment(reinterpret_cast<const char*>(comment_string));

« src/compiler/instruction-selector.cc ('K') | « src/compiler/machine-operator.cc ('k') | src/compiler/mips64/code-generator-mips64.cc » ('j') | src/compiler/opcodes.h » ('J')