Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Side by Side Diff: src/compiler/verifier.cc

Issue 2177483002: [turbofan] Handle impossible types (Type::None()) in the backend. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix?? Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/verifier.h" 5 #include "src/compiler/verifier.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <deque> 8 #include <deque>
9 #include <queue> 9 #include <queue>
10 #include <sstream> 10 #include <sstream>
(...skipping 928 matching lines...) Expand 10 before | Expand all | Expand 10 after
939 } 939 }
940 case IrOpcode::kTruncateTaggedToWord32: { 940 case IrOpcode::kTruncateTaggedToWord32: {
941 // Number /\ Tagged -> Signed32 /\ UntaggedInt32 941 // Number /\ Tagged -> Signed32 /\ UntaggedInt32
942 // TODO(neis): Activate once ChangeRepresentation works in typer. 942 // TODO(neis): Activate once ChangeRepresentation works in typer.
943 // Type* from = Type::Intersect(Type::Number(), Type::Tagged()); 943 // Type* from = Type::Intersect(Type::Number(), Type::Tagged());
944 // Type* to = Type::Intersect(Type::Number(), Type::UntaggedInt32()); 944 // Type* to = Type::Intersect(Type::Number(), Type::UntaggedInt32());
945 // CheckValueInputIs(node, 0, from)); 945 // CheckValueInputIs(node, 0, from));
946 // CheckUpperIs(node, to)); 946 // CheckUpperIs(node, to));
947 break; 947 break;
948 } 948 }
949 case IrOpcode::kImpossibleToWord32:
950 case IrOpcode::kImpossibleToWord64:
951 case IrOpcode::kImpossibleToFloat32:
952 case IrOpcode::kImpossibleToFloat64:
953 case IrOpcode::kImpossibleToTagged:
954 case IrOpcode::kImpossibleToBit:
955 break;
949 956
950 case IrOpcode::kCheckBounds: 957 case IrOpcode::kCheckBounds:
951 CheckValueInputIs(node, 0, Type::Any()); 958 CheckValueInputIs(node, 0, Type::Any());
952 CheckValueInputIs(node, 1, Type::Unsigned31()); 959 CheckValueInputIs(node, 1, Type::Unsigned31());
953 CheckUpperIs(node, Type::Unsigned31()); 960 CheckUpperIs(node, Type::Unsigned31());
954 break; 961 break;
955 case IrOpcode::kCheckNumber: 962 case IrOpcode::kCheckNumber:
956 CheckValueInputIs(node, 0, Type::Any()); 963 CheckValueInputIs(node, 0, Type::Any());
957 CheckUpperIs(node, Type::Number()); 964 CheckUpperIs(node, Type::Number());
958 break; 965 break;
(...skipping 556 matching lines...) Expand 10 before | Expand all | Expand 10 after
1515 replacement->op()->EffectOutputCount() > 0); 1522 replacement->op()->EffectOutputCount() > 0);
1516 DCHECK(!NodeProperties::IsFrameStateEdge(edge) || 1523 DCHECK(!NodeProperties::IsFrameStateEdge(edge) ||
1517 replacement->opcode() == IrOpcode::kFrameState); 1524 replacement->opcode() == IrOpcode::kFrameState);
1518 } 1525 }
1519 1526
1520 #endif // DEBUG 1527 #endif // DEBUG
1521 1528
1522 } // namespace compiler 1529 } // namespace compiler
1523 } // namespace internal 1530 } // namespace internal
1524 } // namespace v8 1531 } // namespace v8
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698