Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2177473004: Switch to a java exception in assertOnUiThread. (Closed)

Created:
4 years, 5 months ago by Ted C
Modified:
4 years, 5 months ago
Reviewers:
Yaron
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch to a java exception in assertOnUiThread. Not enough coverage for the asserts at the moment (hopefully, we will get them back with the newer android toolchains eventually), and this seems like an important enough one to special case. Context: https://codereview.chromium.org/2165333002/#msg9 BUG= Committed: https://crrev.com/b9ca2ee1de46813ca8831d456331d386e4fa98b3 Cr-Commit-Position: refs/heads/master@{#407200}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M base/android/java/src/org/chromium/base/ThreadUtils.java View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
Ted C
PTAL
4 years, 5 months ago (2016-07-22 16:22:37 UTC) #2
Yaron
On 2016/07/22 16:22:37, Ted C wrote: > PTAL lgtm I think this actually does have ...
4 years, 5 months ago (2016-07-22 17:11:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2177473004/1
4 years, 5 months ago (2016-07-22 17:14:10 UTC) #6
Ted C
On 2016/07/22 17:11:51, Yaron wrote: > On 2016/07/22 16:22:37, Ted C wrote: > > PTAL ...
4 years, 5 months ago (2016-07-22 17:14:34 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 18:00:55 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 18:03:16 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b9ca2ee1de46813ca8831d456331d386e4fa98b3
Cr-Commit-Position: refs/heads/master@{#407200}

Powered by Google App Engine
This is Rietveld 408576698