Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 2177433002: [Editing][Codehealth] Improve startOfParagraphAlgorithm readbility (Closed)

Created:
4 years, 5 months ago by yoichio
Modified:
4 years, 5 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Editing][Codehealth] Improve startOfParagraphAlgorithm readbility Rename and sort variables, Extract function body to receive and return Position. TEST=No change in behavior. Committed: https://crrev.com/df7da06bf292a1094b2518c8c5773c57f93cd5c2 Cr-Commit-Position: refs/heads/master@{#407111}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -46 lines) Patch
M third_party/WebKit/Source/core/editing/VisibleUnits.cpp View 1 chunk +50 lines, -46 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
yoichio
4 years, 5 months ago (2016-07-22 09:13:39 UTC) #5
yosin_UTC9
lgtm
4 years, 5 months ago (2016-07-22 09:30:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2177433002/1
4 years, 5 months ago (2016-07-22 09:30:36 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 09:34:02 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 09:35:41 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/df7da06bf292a1094b2518c8c5773c57f93cd5c2
Cr-Commit-Position: refs/heads/master@{#407111}

Powered by Google App Engine
This is Rietveld 408576698