Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(778)

Issue 2177393003: Revert "Apply disable_discard_framebuffer workaround to Adreno 5xx." (Closed)

Created:
4 years, 4 months ago by aelias_OOO_until_Jul13
Modified:
4 years, 4 months ago
Reviewers:
no sievers
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Apply disable_discard_framebuffer workaround to Adreno 5xx." This reverts commit 010e950035a84e3d4b4155c35b7eaedbc7e227c2. I set this workaround flag based on misreading a crash report, and there's actually no evidence that Adreno 5xx has any bugs with framebuffer discarding. BUG=612474 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/556c2dbf8717f2a2eb58e06cd341cf8aa03453a9 Cr-Commit-Position: refs/heads/master@{#407677}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -13 lines) Patch
M gpu/config/gpu_driver_bug_list_json.cc View 2 chunks +1 line, -13 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
aelias_OOO_until_Jul13
PTAL
4 years, 4 months ago (2016-07-26 00:47:43 UTC) #5
no sievers
lgtm
4 years, 4 months ago (2016-07-26 01:04:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2177393003/1
4 years, 4 months ago (2016-07-26 01:06:15 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-26 01:40:47 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 01:43:54 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/556c2dbf8717f2a2eb58e06cd341cf8aa03453a9
Cr-Commit-Position: refs/heads/master@{#407677}

Powered by Google App Engine
This is Rietveld 408576698