Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2177383004: Revert "binding: Window-returning attributes return null if a Window is detached." (Closed)

Created:
4 years, 5 months ago by Yuki
Modified:
4 years, 5 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "binding: Window-returning attributes return null if a Window is detached." This reverts commit eb73fb7bd81b3253a36171851da62e15e5f88b41. The root cause of https://crbug.com/621730 was not related to the binding layer, and https://crrev.com/2085983002 caused regressions as reported at https://crbug.com/629840 , so let's revert the CL. BUG=629840, 621730 Committed: https://crrev.com/3744fab24dd32abd9ffe76ccc77a4d21ae59ab3a Cr-Commit-Position: refs/heads/master@{#407750}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -17 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ToV8.cpp View 1 chunk +4 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/frame/DOMWindow.cpp View 2 chunks +2 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Yuki
Could you review this CL?
4 years, 5 months ago (2016-07-26 07:57:13 UTC) #3
haraken
LGTM
4 years, 5 months ago (2016-07-26 08:09:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2177383004/1
4 years, 5 months ago (2016-07-26 09:31:45 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-26 09:35:19 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-26 09:38:15 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3744fab24dd32abd9ffe76ccc77a4d21ae59ab3a
Cr-Commit-Position: refs/heads/master@{#407750}

Powered by Google App Engine
This is Rietveld 408576698