Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2177383003:
[Devtools] Added Copy All as cURL to network log (Closed)
|
Created:
4 years, 5 months ago by allada Modified:
4 years, 4 months ago Reviewers:
lushnikov CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Devtools] Added Copy All as cURL to network log
Added a context menu option which you can get all requests seperated by
a semicolon and new lines for users that want to get all or most of the
requests as curl commands from devtools
BUG=466923
Committed: https://crrev.com/b4c701d254dd0b6f94acae1b4cb08e9c95751b0f
Cr-Commit-Position: refs/heads/master@{#408257}
Patch Set 1 #
Total comments: 8
Patch Set 2 : changes #
Total comments: 4
Patch Set 3 : requested changes #
Messages
Total messages: 21 (11 generated)
allada@chromium.org changed reviewers: + lushnikov@chromium.org
PTL
https://codereview.chromium.org/2177383003/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js (right): https://codereview.chromium.org/2177383003/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:860: contextMenu.appendItem(WebInspector.UIString("Copy All as cURL (cmd)"), this._copyAllCurlCommand.bind(this, "win")); maybe it's time to introduce the "Copy..." submenu? https://codereview.chromium.org/2177383003/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:965: _copyAllCurlCommand: function(platform) let's make a bool argument "useCRLF" https://codereview.chromium.org/2177383003/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:967: var requests = this._nodesByRequestId.valuesArray().map(function(node) { return node.request(); }); .map(node => node.request()); https://codereview.chromium.org/2177383003/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:971: var newLineChars = "\n"; var newLine = platform === "win" ? "\r\n" : "\n";
Patchset #2 (id:20001) has been deleted
PTL https://codereview.chromium.org/2177383003/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js (right): https://codereview.chromium.org/2177383003/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:860: contextMenu.appendItem(WebInspector.UIString("Copy All as cURL (cmd)"), this._copyAllCurlCommand.bind(this, "win")); On 2016/07/26 01:23:09, lushnikov wrote: > maybe it's time to introduce the "Copy..." submenu? Done. https://codereview.chromium.org/2177383003/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:965: _copyAllCurlCommand: function(platform) On 2016/07/26 01:23:09, lushnikov wrote: > let's make a bool argument "useCRLF" _generateCurlCommand() needs platform. https://codereview.chromium.org/2177383003/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:967: var requests = this._nodesByRequestId.valuesArray().map(function(node) { return node.request(); }); On 2016/07/26 01:23:09, lushnikov wrote: > .map(node => node.request()); Done. https://codereview.chromium.org/2177383003/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:971: var newLineChars = "\n"; On 2016/07/26 01:23:09, lushnikov wrote: > var newLine = platform === "win" ? "\r\n" : "\n"; Done.
lgtm https://codereview.chromium.org/2177383003/diff/40001/third_party/WebKit/Sour... File third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js (right): https://codereview.chromium.org/2177383003/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:845: var copyMenu = contextMenu.appendSubMenuItem(WebInspector.UIString("Copy...")); Let's drop the "..." to be consistent with Elements panel context menu https://codereview.chromium.org/2177383003/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:975: InspectorFrontendHost.copyText(commands.join(" ;" + newLine)); why " ;"?
done https://codereview.chromium.org/2177383003/diff/40001/third_party/WebKit/Sour... File third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js (right): https://codereview.chromium.org/2177383003/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:845: var copyMenu = contextMenu.appendSubMenuItem(WebInspector.UIString("Copy...")); On 2016/07/26 22:52:11, lushnikov wrote: > Let's drop the "..." to be consistent with Elements panel context menu Done. https://codereview.chromium.org/2177383003/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:975: InspectorFrontendHost.copyText(commands.join(" ;" + newLine)); On 2016/07/26 22:52:11, lushnikov wrote: > why " ;"? This allows the commands to be ran just by pasting it in without any modification. Windows uses & and bash uses ;.
The CQ bit was checked by allada@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by allada@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from lushnikov@chromium.org Link to the patchset: https://codereview.chromium.org/2177383003/#ps60001 (title: "requested changes")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by allada@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #3 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== [Devtools] Added Copy All as cURL to network log Added a context menu option which you can get all requests seperated by a semicolon and new lines for users that want to get all or most of the requests as curl commands from devtools BUG=466923 ========== to ========== [Devtools] Added Copy All as cURL to network log Added a context menu option which you can get all requests seperated by a semicolon and new lines for users that want to get all or most of the requests as curl commands from devtools BUG=466923 Committed: https://crrev.com/b4c701d254dd0b6f94acae1b4cb08e9c95751b0f Cr-Commit-Position: refs/heads/master@{#408257} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/b4c701d254dd0b6f94acae1b4cb08e9c95751b0f Cr-Commit-Position: refs/heads/master@{#408257} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
