Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2177373002: Revert of Revert disabled test for crbug/419370 (Closed)

Created:
4 years, 5 months ago by Mark P
Modified:
4 years, 5 months ago
Reviewers:
Dan Beam, kochi
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert disabled test for crbug/419370 (patchset #2 id:20001 of https://codereview.chromium.org/2174743002/ ) Reason for revert: Newly re-enabled tests crash consistently on Linux ChromiumOS Tests (dbg)(1) bot. https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29 StartupPageListWebUITest.testDropFromOutsideSource (run #1): [ RUN ] StartupPageListWebUITest.testDropFromOutsideSource [28436:28436:0725/125631:WARNING:chrome_browser_main_chromeos.cc(332)] Running as stub user with profile dir: test-user [28436:28436:0725/125631:WARNING:audio_manager.cc(317)] Multiple instances of AudioManager detected [28436:28436:0725/125631:WARNING:audio_manager.cc(278)] Multiple instances of AudioManager detected [28436:28436:0725/125631:ERROR:logging_chrome.cc(173)] Unable to create symlink /tmp/.org.chromium.Chromium.2OfPzc/dVYVbTE/test-user/chrome_debug.log pointing at /tmp/.org.chromium.Chromium.2OfPzc/dVYVbTE/test-user/chrome_debug_20160725-125631.log: No such file or directory Xlib: extension "RANDR" missing on display ":9". [28436:28474:0725/125631:WARNING:local_extension_cache.cc(259)] Extensions will not be installed from update URLs until /tmp/.org.chromium.Chromium.2OfPzc/dVYVbTE/stub_device_local_extension_cache/.initialized exists. [28436:28436:0725/125632:WARNING:child_account_service.cc(302)] User instance wasn't found while setting child account flag. [28436:28459:0725/125632:WARNING:freezer_cgroup_process_manager.cc(59)] Cgroup freezer does not exist or is not writable. Unable to freeze renderer processes. [28470:28497:0725/125633:ERROR:node_controller.cc(1099)] Could not be introduced to peer 92B1CCD4AD67F70B.12EAFA42C6B0A7E0 [28436:28436:0725/125635:WARNING:CONSOLE(1084)] "/deep/ combinator is deprecated. See https://www.chromestatus.com/features/6750456638341120 for more details.", source: chrome://resources/js/cr/ui/list.js (1084) [28436:28436:0725/125636:ERROR:device_event_log_impl.cc(140)] [12:56:37.003] Network: ui_proxy_config_service.cc:91 No configured NetworkState for guid: [28436:28436:0725/125637:WARNING:user_image_source.cc(39)] Failed to deserialize account_id. [28436:28436:0725/125639:INFO:CONSOLE(1206)] "Running TestCase StartupPageListWebUITest.testDropFromOutsideSource", source: test_api.js (1206) BrowserTestBase signal handler received SIGTERM. Backtrace: #0 0x7f8ac44f2c0e base::debug::StackTrace::StackTrace() #1 0x0000042772fa content::(anonymous namespace)::DumpStackTraceSignalHandler() #2 0x7f8aab0c00b0 <unknown> #3 0x7f8aab171993 __poll #4 0x7f8aaef36ff6 <unknown> #5 0x7f8aaef37124 g_main_context_iteration #6 0x7f8ac45857df base::MessagePumpGlib::Run() #7 0x7f8ac456fb8a base::MessageLoop::RunHandler() #8 0x7f8ac460bd94 base::RunLoop::Run() #9 0x0000042fc3b6 content::RunThisRunLoop() #10 0x0000042fc34a content::RunMessageLoop() #11 0x0000012ed456 WebUITestHandler::WaitForResult() #12 0x0000012ed129 WebUITestHandler::RunJavaScriptTestWithResult() #13 0x0000013d62b7 WebUIBrowserTest::RunJavascriptUsingHandler() #14 0x0000013d67f2 WebUIBrowserTest::RunJavascriptTest() #15 0x0000013d6741 WebUIBrowserTest::RunJavascriptTestF() #16 0x0000018b53eb StartupPageListWebUITest_testDropFromOutsideSource_Test::RunTestOnMainThread() #17 0x000003558718 InProcessBrowserTest::RunTestOnMainThreadLoop() #18 0x0000042770c1 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #19 0x0000009d3b02 _ZN4base8internal13FunctorTraitsIM24DevToolsBeforeUnloadTestFvvEvE6InvokeIRK13scoped_refptrI53DevToolsBeforeUnloadTest_TestDockedDevToolsClose_TestEJEEEvS4_OT_DpOT0_ #20 0x000004278221 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKMN7content15BrowserTestBaseEFvvEJRK13scoped_refptrIS5_EEEEvOT_DpOT0_ #21 0x0000042781c2 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJ13scoped_refptrIS4_EEEEFvvEE7RunImplIRKS6_RKSt5tupleIJS8_EEJLm0EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE #22 0x000004277fec _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJ13scoped_refptrIS4_EEEEFvvEE3RunEPNS0_13BindStateBaseE #23 0x000000879aae base::Callback<>::Run() #24 0x0000035f7089 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #25 0x0000035f5e00 ChromeBrowserMainParts::PreMainMessageLoopRun() #26 0x000001a0d245 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #27 0x7f8abc36e591 content::BrowserMainLoop::PreMainMessageLoopRun() #28 0x7f8abbae46ed _ZN4base8internal13FunctorTraitsIMN4mojo10BindingSetIN7content5mojom14ProcessControlEE7ElementEFvvEvE6InvokeIPS8_JEEEvSA_OT_DpOT0_ #29 0x7f8abc3762f1 _ZN4base8internal12InvokeHelperILb0EiE8MakeItSoIRKMN7content15BrowserMainLoopEFivEJPS5_EEEiOT_DpOT0_ #30 0x7f8abc376297 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE7RunImplIRKS6_RKSt5tupleIJS8_EEJLm0EEEEiOT_OT0_NS_13IndexSequenceIJXspT1_EEEE #31 0x7f8abc3761fc _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE3RunEPNS0_13BindStateBaseE #32 0x7f8abbae479e base::Callback<>::Run() #33 0x7f8abcd6669b content::StartupTaskRunner::RunAllTasksNow() #34 0x7f8abc36c613 content::BrowserMainLoop::CreateStartupTasks() #35 0x7f8abc37876d content::BrowserMainRunnerImpl::Initialize() #36 0x7f8abc368cdd content::BrowserMain() #37 0x7f8abdc24c06 content::RunNamedProcessTypeMain() #38 0x7f8abdc26ca5 content::ContentMainRunnerImpl::Run() #39 0x7f8abdc23e42 content::ContentMain() #40 0x000004276e1d content::BrowserTestBase::SetUp() #41 0x000003557244 InProcessBrowserTest::SetUp() #42 0x00000081d27a _ZN7testing8internal12InvokeHelperIRKNSt7__debug6vectorIPN12user_manager4UserESaIS6_EEESt5tupleIJEEE12InvokeMethodIN8chromeos15MockUserManagerEMSG_KFSA_vEEESA_PT_T0_RKSC_ #43 0x00000440ad0e testing::internal::HandleExceptionsInMethodIfSupported<>() #44 0x000004400023 testing::Test::Run() #45 0x000004400798 testing::TestInfo::Run() #46 0x000004400d3a testing::TestCase::Run() #47 0x00000440608c testing::internal::UnitTestImpl::RunAllTests() #48 0x00000441acca testing::internal::HandleSehExceptionsInMethodIfSupported<>() #49 0x00000440c31e testing::internal::HandleExceptionsInMethodIfSupported<>() #50 0x000004405d2f testing::UnitTest::Run() #51 0x000003568e61 RUN_ALL_TESTS() #52 0x000003567dd2 base::TestSuite::Run() #53 0x00000351cb32 ChromeTestSuiteRunner::RunTestSuite() #54 0x00000351cc19 ChromeTestLauncherDelegate::RunTestSuite() #55 0x0000042f0145 content::LaunchTests() #56 0x00000351cf39 LaunchChromeTests() #57 0x0000007f8f74 main #58 0x7f8aab0ab7ed __libc_start_main #59 0x0000007f8e05 <unknown> StartupPageListWebUITest.testDropToReorder (run #1): [ RUN ] StartupPageListWebUITest.testDropToReorder [28506:28506:0725/125636:WARNING:chrome_browser_main_chromeos.cc(332)] Running as stub user with profile dir: test-user [28506:28506:0725/125636:WARNING:audio_manager.cc(317)] Multiple instances of AudioManager detected [28506:28506:0725/125636:WARNING:audio_manager.cc(278)] Multiple instances of AudioManager detected [28506:28506:0725/125636:ERROR:logging_chrome.cc(173)] Unable to create symlink /tmp/.org.chromium.Chromium.2OfPzc/dEqao8B/test-user/chrome_debug.log pointing at /tmp/.org.chromium.Chromium.2OfPzc/dEqao8B/test-user/chrome_debug_20160725-125636.log: No such file or directory Xlib: extension "RANDR" missing on display ":9". [28506:28528:0725/125637:WARNING:local_extension_cache.cc(259)] Extensions will not be installed from update URLs until /tmp/.org.chromium.Chromium.2OfPzc/dEqao8B/stub_device_local_extension_cache/.initialized exists. [28506:28506:0725/125637:WARNING:child_account_service.cc(302)] User instance wasn't found while setting child account flag. [28506:28531:0725/125637:WARNING:freezer_cgroup_process_manager.cc(59)] Cgroup freezer does not exist or is not writable. Unable to freeze renderer processes. [28544:28566:0725/125639:ERROR:node_controller.cc(1099)] Could not be introduced to peer 72E0750553B9F697.FCC163B203A2E18 [28506:28506:0725/125641:WARNING:CONSOLE(1084)] "/deep/ combinator is deprecated. See https://www.chromestatus.com/features/6750456638341120 for more details.", source: chrome://resources/js/cr/ui/list.js (1084) [28506:28506:0725/125643:ERROR:device_event_log_impl.cc(140)] [12:56:43.459] Network: ui_proxy_config_service.cc:91 No configured NetworkState for guid: [28506:28506:0725/125643:WARNING:user_image_source.cc(39)] Failed to deserialize account_id. [28506:28506:0725/125646:INFO:CONSOLE(1206)] "Running TestCase StartupPageListWebUITest.testDropToReorder", source: test_api.js (1206) BrowserTestBase signal handler received SIGTERM. Backtrace: #0 0x7fe75e022c0e base::debug::StackTrace::StackTrace() #1 0x0000042772fa content::(anonymous namespace)::DumpStackTraceSignalHandler() #2 0x7fe744bf00b0 <unknown> #3 0x7fe744ca1993 __poll #4 0x7fe748a66ff6 <unknown> #5 0x7fe748a67124 g_main_context_iteration #6 0x7fe75e0b57df base::MessagePumpGlib::Run() #7 0x7fe75e09fb8a base::MessageLoop::RunHandler() #8 0x7fe75e13bd94 base::RunLoop::Run() #9 0x0000042fc3b6 content::RunThisRunLoop() #10 0x0000042fc34a content::RunMessageLoop() #11 0x0000012ed456 WebUITestHandler::WaitForResult() #12 0x0000012ed129 WebUITestHandler::RunJavaScriptTestWithResult() #13 0x0000013d62b7 WebUIBrowserTest::RunJavascriptUsingHandler() #14 0x0000013d67f2 WebUIBrowserTest::RunJavascriptTest() #15 0x0000013d6741 WebUIBrowserTest::RunJavascriptTestF() #16 0x0000018b570b StartupPageListWebUITest_testDropToReorder_Test::RunTestOnMainThread() #17 0x000003558718 InProcessBrowserTest::RunTestOnMainThreadLoop() #18 0x0000042770c1 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #19 0x0000009d3b02 _ZN4base8internal13FunctorTraitsIM24DevToolsBeforeUnloadTestFvvEvE6InvokeIRK13scoped_refptrI53DevToolsBeforeUnloadTest_TestDockedDevToolsClose_TestEJEEEvS4_OT_DpOT0_ #20 0x000004278221 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKMN7content15BrowserTestBaseEFvvEJRK13scoped_refptrIS5_EEEEvOT_DpOT0_ #21 0x0000042781c2 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJ13scoped_refptrIS4_EEEEFvvEE7RunImplIRKS6_RKSt5tupleIJS8_EEJLm0EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE #22 0x000004277fec _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJ13scoped_refptrIS4_EEEEFvvEE3RunEPNS0_13BindStateBaseE #23 0x000000879aae base::Callback<>::Run() #24 0x0000035f7089 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #25 0x0000035f5e00 ChromeBrowserMainParts::PreMainMessageLoopRun() #26 0x000001a0d245 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #27 0x7fe755e9e591 content::BrowserMainLoop::PreMainMessageLoopRun() #28 0x7fe7556146ed _ZN4base8internal13FunctorTraitsIMN4mojo10BindingSetIN7content5mojom14ProcessControlEE7ElementEFvvEvE6InvokeIPS8_JEEEvSA_OT_DpOT0_ #29 0x7fe755ea62f1 _ZN4base8internal12InvokeHelperILb0EiE8MakeItSoIRKMN7content15BrowserMainLoopEFivEJPS5_EEEiOT_DpOT0_ #30 0x7fe755ea6297 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE7RunImplIRKS6_RKSt5tupleIJS8_EEJLm0EEEEiOT_OT0_NS_13IndexSequenceIJXspT1_EEEE #31 0x7fe755ea61fc _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE3RunEPNS0_13BindStateBaseE #32 0x7fe75561479e base::Callback<>::Run() #33 0x7fe75689669b content::StartupTaskRunner::RunAllTasksNow() #34 0x7fe755e9c613 content::BrowserMainLoop::CreateStartupTasks() #35 0x7fe755ea876d content::BrowserMainRunnerImpl::Initialize() #36 0x7fe755e98cdd content::BrowserMain() #37 0x7fe757754c06 content::RunNamedProcessTypeMain() #38 0x7fe757756ca5 content::ContentMainRunnerImpl::Run() #39 0x7fe757753e42 content::ContentMain() #40 0x000004276e1d content::BrowserTestBase::SetUp() #41 0x000003557244 InProcessBrowserTest::SetUp() #42 0x00000081d27a _ZN7testing8internal12InvokeHelperIRKNSt7__debug6vectorIPN12user_manager4UserESaIS6_EEESt5tupleIJEEE12InvokeMethodIN8chromeos15MockUserManagerEMSG_KFSA_vEEESA_PT_T0_RKSC_ #43 0x00000440ad0e testing::internal::HandleExceptionsInMethodIfSupported<>() #44 0x000004400023 testing::Test::Run() #45 0x000004400798 testing::TestInfo::Run() #46 0x000004400d3a testing::TestCase::Run() #47 0x00000440608c testing::internal::UnitTestImpl::RunAllTests() #48 0x00000441acca testing::internal::HandleSehExceptionsInMethodIfSupported<>() #49 0x00000440c31e testing::internal::HandleExceptionsInMethodIfSupported<>() #50 0x000004405d2f testing::UnitTest::Run() #51 0x000003568e61 RUN_ALL_TESTS() #52 0x000003567dd2 base::TestSuite::Run() #53 0x00000351cb32 ChromeTestSuiteRunner::RunTestSuite() #54 0x00000351cc19 ChromeTestLauncherDelegate::RunTestSuite() #55 0x0000042f0145 content::LaunchTests() #56 0x00000351cf39 LaunchChromeTests() #57 0x0000007f8f74 main #58 0x7fe744bdb7ed __libc_start_main #59 0x0000007f8e05 <unknown> Original issue's description: > Revert disabled test for crbug/419370 > > The disabled test seems to have hit assertion in the old code, > which does not exist today. > Removing 'DISABLED_' prefix to revive those tests. > > BUG=419370 > > Committed: https://crrev.com/73e67742737ad7cdfaeabf162d97857ee321278a > Cr-Commit-Position: refs/heads/master@{#407414} TBR=dbeam@chromium.org,kochi@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=419370 Committed: https://crrev.com/2fe4e328552fe9e4f38b66be416c6be5d113113b Cr-Commit-Position: refs/heads/master@{#407611}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/browser/ui/webui/options/startup_page_list_browsertest.js View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Mark P
Created Revert of Revert disabled test for crbug/419370
4 years, 5 months ago (2016-07-25 22:06:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2177373002/1
4 years, 5 months ago (2016-07-25 22:07:14 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-25 22:07:50 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 22:10:03 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/2fe4e328552fe9e4f38b66be416c6be5d113113b
Cr-Commit-Position: refs/heads/master@{#407611}

Powered by Google App Engine
This is Rietveld 408576698