appengine/swarming/elements/Makefile - Issue 2177353002: Add top level app element

Side by Side Diff: appengine/swarming/elements/Makefile

Issue 2177353002: Add top level app element (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-py@hello-oauth

Patch Set: Actually delete stats Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright 2016 The LUCI Authors. All rights reserved.	1 # Copyright 2016 The LUCI Authors. All rights reserved.

2 # Use of this source code is governed by the Apache v2.0 license that can be	2 # Use of this source code is governed by the Apache v2.0 license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 # Set up the local directory to run the demo pages.	5 # Set up the local directory to run the demo pages.

6	6

7 default:	7 default:

8 bower install	8 bower install

9	9

10 # Run a local HTTP server for the demo pages.	10 # Run a local HTTP server for the demo pages.

11 .PHONY: run	11 .PHONY: run

12 run: default	12 run: default

13 » node_modules/.bin/http-server -p 8080 -a 127.0.0.1	13 » -wget -nc --output-document=./imp/botlist/bot-list-demo.json https://sto rage.googleapis.com/luci-demo-data/swarming/bot-list-demo.json

	14

	15 » node_modules/.bin/http-server -p 9050 -a 127.0.0.1

14	16

15	17

16 .PHONY: vulcanize	18 .PHONY: vulcanize

17 vulcanize:	19 vulcanize:

18 ./node_modules/.bin/vulcanize --inline-css=true --inline-scripts=true -- strip-comments=true --out-html=./build/index-build.html index.html	20 ./node_modules/.bin/vulcanize --inline-css=true --inline-scripts=true -- strip-comments=true --out-html=./build/index-build.html index.html

19 » ./node_modules/.bin/vulcanize --inline-css=true --inline-scripts=true -- strip-comments=true --out-html=./build/botlist-build.html botlist.html	21 » ./node_modules/.bin/vulcanize --inline-css=true --inline-scripts=true -- strip-comments=true --out-html=./build/botlist-build.html botlist-index.html

20	22

21 .PHONY: clean_vulcanize	23 .PHONY: clean_vulcanize

22 clean_vulcanize: default	24 clean_vulcanize: default

23 rm -f ./build/*build.html	25 rm -f ./build/*build.html

24 ./node_modules/.bin/vulcanize --inline-css=true --inline-scripts=true -- strip-comments=true --out-html=./build/index-build.html index.html	26 ./node_modules/.bin/vulcanize --inline-css=true --inline-scripts=true -- strip-comments=true --out-html=./build/index-build.html index.html
	jcgregorio 2016/07/26 12:55:09 Instead of vulcanizing index.html and botlist-inde Instead of vulcanizing index.html and botlist-index.html individually, there should be a single file 'elements.html' that lists the top level elements, i.e. swarming-app, swarming-index that gets vulcanized into a single file ./build/elements.html that gets imported by both index.html and botlist.html. The advantage is that while the file will be larger, you will only need to download it once regardless of which page you move to. It also reduces the number of generated files to be checked into the git repo to just one, the vulcanized elements.html. Note that the two index files will need to import the web components polyfill and then HTML import the elements.html file. This will also enable 'debug' mode, which can be done in a later CL, which is where you don't vulcanize elements.html and it just imports all of it's dependents individually, which is slower, but makes developing and debugging much easier. kjlubick 2016/07/26 13:56:00 Done. The elements is served out of /res/elements Show quoted text On 2016/07/26 at 12:55:09, jcgregorio wrote: > Instead of vulcanizing index.html and botlist-index.html individually, there should be a single file 'elements.html' that lists the top level elements, i.e. swarming-app, swarming-index that gets vulcanized into a single file ./build/elements.html that gets imported by both index.html and botlist.html. The advantage is that while the file will be larger, you will only need to download it once regardless of which page you move to. > > It also reduces the number of generated files to be checked into the git repo to just one, the vulcanized elements.html. > > Note that the two index files will need to import the web components polyfill and then HTML import the elements.html file. > > This will also enable 'debug' mode, which can be done in a later CL, which is where you don't vulcanize elements.html and it just imports all of it's dependents individually, which is slower, but makes developing and debugging much easier. Done. The elements is served out of /res/elements.html, along with /res/[polyfill].js
25 » ./node_modules/.bin/vulcanize --inline-css=true --inline-scripts=true -- strip-comments=true --out-html=./build/botlist-build.html botlist.html	27 » ./node_modules/.bin/vulcanize --inline-css=true --inline-scripts=true -- strip-comments=true --out-html=./build/botlist-build.html botlist-index.html

	28

	29 .PHONY: dev_deploy

	30 dev_deploy: clean_vulcanize

	31 » ../tools/gae upl -A chromium-swarm-dev

	32

	33 .PHONY: deploy

	34 deploy: clean_vulcanize

	35 » ../tools/gae upl -A chromium-swarm

OLD	NEW

« no previous file with comments | « no previous file | appengine/swarming/elements/README.md » ('j') | appengine/swarming/elements/imp/stats/load-charts-api.html » ('J')