components/spellcheck.gypi - Issue 2177343002: Componentize spellcheck [2]: move common/ files to component.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/spellcheck.gypi

Issue 2177343002: Componentize spellcheck [2]: move common/ files to component. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix mac bots a bit more Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/spellchecker/spellcheck_unittest.cc ('k') | components/spellcheck/common/BUILD.gn » ('j') | components/spellcheck/common/spellcheck_common.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/spellcheck.gypi

diff --git a/components/spellcheck.gypi b/components/spellcheck.gypi

index 064f3c7ee7262195d5fc2ea698b6c51fd7f3ab40..d315d3cd1dcec82bb6259cc18186693852394158 100644

--- a/components/spellcheck.gypi

+++ b/components/spellcheck.gypi

@@ -8,10 +8,20 @@

# GN version: //components/spellcheck/common

'target_name': 'spellcheck_common',

'type': 'static_library',

+ 'dependencies': [

+ '../third_party/icu/icu.gyp:icui18n',

+ '../third_party/icu/icu.gyp:icuuc',

+ ],

'include_dirs': [

'..',

'sources': [

+ "spellcheck/common/spellcheck_bdict_language.h",

+ "spellcheck/common/spellcheck_common.cc",

+ "spellcheck/common/spellcheck_common.h",

+ "spellcheck/common/spellcheck_marker.h",

+ "spellcheck/common/spellcheck_messages.h",

+ "spellcheck/common/spellcheck_result.h",

'spellcheck/common/spellcheck_switches.cc',

'spellcheck/common/spellcheck_switches.h',