chrome/chrome_common.gypi - Issue 2177343002: Componentize spellcheck [2]: move common/ files to component.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_common.gypi

Issue 2177343002: Componentize spellcheck [2]: move common/ files to component. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix mac bots a bit more Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/options/language_options_handler_common.cc ('k') | chrome/common/BUILD.gn » ('j') | components/spellcheck/common/spellcheck_common.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/chrome_common.gypi

diff --git a/chrome/chrome_common.gypi b/chrome/chrome_common.gypi

index 8b2915e2dcf12d3b31b3c5d1c5b2ab98cb193819..69d3722f254ffa799004d1f9d802194427291fc9 100644

--- a/chrome/chrome_common.gypi

+++ b/chrome/chrome_common.gypi

@@ -86,12 +86,6 @@

'common/search_provider.h',

'common/secure_origin_whitelist.cc',

'common/secure_origin_whitelist.h',

- 'common/spellcheck_bdict_language.h',

- 'common/spellcheck_common.cc',

- 'common/spellcheck_common.h',

- 'common/spellcheck_marker.h',

- 'common/spellcheck_messages.h',

- 'common/spellcheck_result.h',

'common/ssl_insecure_content.cc',

'common/ssl_insecure_content.h',

'common/switch_utils.cc',

@@ -435,7 +429,6 @@

['exclude', '^common/multi_process_'],

['exclude', '^common/profiling\\.'],

['exclude', '^common/resource_usage_reporter_type_converters'],

- ['exclude', '^common/spellcheck_'],

['exclude', '^common/validation_message_'],

['exclude', '^common/web_apps\\.'],

# TODO(ios): Include files here as they are made to work; once