Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Unified Diff: third_party/WebKit/Source/core/page/ChromeClient.h

Issue 2177333002: Move setWindowRect and windowRect calls from WebViewClient to WebWidgetClient. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: change CHECK to a DCHECK Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/page/ChromeClient.h
diff --git a/third_party/WebKit/Source/core/page/ChromeClient.h b/third_party/WebKit/Source/core/page/ChromeClient.h
index 762d7844a784f046c7bdad2895f671c6c6d7b628..2b2e42eeba31e6d23dd141c5e39777f7b6d6324b 100644
--- a/third_party/WebKit/Source/core/page/ChromeClient.h
+++ b/third_party/WebKit/Source/core/page/ChromeClient.h
@@ -85,8 +85,8 @@ public:
// The specified rectangle is adjusted for the minimum window size and the
// screen, then setWindowRect with the adjusted rectangle is called.
- void setWindowRectWithAdjustment(const IntRect&);
- virtual IntRect windowRect() = 0;
+ void setWindowRectWithAdjustment(const IntRect&, LocalFrame*);
dcheng 2016/08/15 18:22:44 Let's make this a LocalFrame&.
lfg 2016/08/16 21:02:13 I know this is blink, but this goes against the go
dcheng 2016/08/16 21:03:46 We have a strong convention of passing never-null
+ virtual IntRect rootWindowRect() = 0;
virtual IntRect pageRect() = 0;
@@ -288,7 +288,7 @@ protected:
~ChromeClient() override { }
virtual void showMouseOverURL(const HitTestResult&) = 0;
- virtual void setWindowRect(const IntRect&) = 0;
+ virtual void setWindowRect(const IntRect&, LocalFrame*) = 0;
dcheng 2016/08/15 18:22:44 Ditto
virtual bool openBeforeUnloadConfirmPanelDelegate(LocalFrame*, bool isReload) = 0;
virtual bool openJavaScriptAlertDelegate(LocalFrame*, const String&) = 0;
virtual bool openJavaScriptConfirmDelegate(LocalFrame*, const String&) = 0;

Powered by Google App Engine
This is Rietveld 408576698