content/renderer/render_view_impl.h - Issue 2177333002: Move setWindowRect and windowRect calls from WebViewClient to WebWidgetClient.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_impl.h

Issue 2177333002: Move setWindowRect and windowRect calls from WebViewClient to WebWidgetClient. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: change CHECK to a DCHECK Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/render_view_impl.h

diff --git a/content/renderer/render_view_impl.h b/content/renderer/render_view_impl.h

index 48548f341445e6b972c6b5226729caff708325c2..91c1ea408d2f785e2e60f8175d0706c389e55c6e 100644

--- a/content/renderer/render_view_impl.h

+++ b/content/renderer/render_view_impl.h

@@ -315,12 +315,10 @@ class CONTENT_EXPORT RenderViewImpl

void setToolTipText(const blink::WebString&,

blink::WebTextDirection hint) override;

void setTouchAction(blink::WebTouchAction touchAction) override;

- void setWindowRect(const blink::WebRect& rect) override;

void showImeIfNeeded() override;

void showUnhandledTapUIIfNeeded(const blink::WebPoint& tappedPosition,

const blink::WebNode& tappedNode,

bool pageChanged) override;

- blink::WebRect windowRect() override;

blink::WebRect windowResizerRect() override;

blink::WebWidgetClient* widgetClient() override;

« no previous file with comments | « no previous file | content/renderer/render_view_impl.cc » ('j') | third_party/WebKit/Source/core/page/ChromeClient.h » ('J')