Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Unified Diff: third_party/WebKit/Source/core/page/CreateWindow.cpp

Issue 2177333002: Move setWindowRect and windowRect calls from WebViewClient to WebWidgetClient. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: switch to refs Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/page/CreateWindow.cpp
diff --git a/third_party/WebKit/Source/core/page/CreateWindow.cpp b/third_party/WebKit/Source/core/page/CreateWindow.cpp
index 8d60465cb752e9635959f3486592e0009b85552d..2df6339324422c45b0333fe03fe9aa76956788be 100644
--- a/third_party/WebKit/Source/core/page/CreateWindow.cpp
+++ b/third_party/WebKit/Source/core/page/CreateWindow.cpp
@@ -88,7 +88,7 @@ static Frame* createNewWindow(LocalFrame& openerFrame, const FrameLoadRequest& r
// specify the size of the viewport. We can only resize the window, so adjust
// for the difference between the window size and the viewport size.
- IntRect windowRect = host->chromeClient().windowRect();
+ IntRect windowRect = host->chromeClient().rootWindowRect();
IntSize viewportSize = host->chromeClient().pageRect().size();
if (features.xSet)
@@ -100,7 +100,7 @@ static Frame* createNewWindow(LocalFrame& openerFrame, const FrameLoadRequest& r
if (features.heightSet)
windowRect.setHeight(features.height + (windowRect.height() - viewportSize.height()));
- host->chromeClient().setWindowRectWithAdjustment(windowRect);
+ host->chromeClient().setWindowRectWithAdjustment(windowRect, frame);
host->chromeClient().show(policy);
if (openerFrame.document()->isSandboxed(SandboxPropagatesToAuxiliaryBrowsingContexts))
« no previous file with comments | « third_party/WebKit/Source/core/page/ChromeClient.cpp ('k') | third_party/WebKit/Source/web/ChromeClientImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698