third_party/WebKit/Source/core/page/CreateWindow.cpp - Issue 2177333002: Move setWindowRect and windowRect calls from WebViewClient to WebWidgetClient.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/CreateWindow.cpp

Issue 2177333002: Move setWindowRect and windowRect calls from WebViewClient to WebWidgetClient. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/page/ChromeClient.cpp ('k') | third_party/WebKit/Source/web/ChromeClientImpl.h » ('j') | third_party/WebKit/Source/web/ChromeClientImpl.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/page/CreateWindow.cpp

diff --git a/third_party/WebKit/Source/core/page/CreateWindow.cpp b/third_party/WebKit/Source/core/page/CreateWindow.cpp

index 8d60465cb752e9635959f3486592e0009b85552d..28d6a2fb226207b2b0141d7f4c19d8f0c39b70b5 100644

--- a/third_party/WebKit/Source/core/page/CreateWindow.cpp

+++ b/third_party/WebKit/Source/core/page/CreateWindow.cpp

@@ -88,7 +88,7 @@ static Frame* createNewWindow(LocalFrame& openerFrame, const FrameLoadRequest& r

// specify the size of the viewport. We can only resize the window, so adjust

// for the difference between the window size and the viewport size.

- IntRect windowRect = host->chromeClient().windowRect();

+ IntRect windowRect = host->chromeClient().rootWindowRect();

IntSize viewportSize = host->chromeClient().pageRect().size();

if (features.xSet)

@@ -100,7 +100,7 @@ static Frame* createNewWindow(LocalFrame& openerFrame, const FrameLoadRequest& r

if (features.heightSet)

windowRect.setHeight(features.height + (windowRect.height() - viewportSize.height()));

- host->chromeClient().setWindowRectWithAdjustment(windowRect);

+ host->chromeClient().setWindowRectWithAdjustment(windowRect, &frame);

host->chromeClient().show(policy);

if (openerFrame.document()->isSandboxed(SandboxPropagatesToAuxiliaryBrowsingContexts))