third_party/WebKit/Source/core/page/ChromeClient.h - Issue 2177333002: Move setWindowRect and windowRect calls from WebViewClient to WebWidgetClient.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/ChromeClient.h

Issue 2177333002: Move setWindowRect and windowRect calls from WebViewClient to WebWidgetClient. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/loader/EmptyClients.h ('k') | third_party/WebKit/Source/core/page/ChromeClient.cpp » ('j') | third_party/WebKit/Source/web/ChromeClientImpl.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/page/ChromeClient.h

diff --git a/third_party/WebKit/Source/core/page/ChromeClient.h b/third_party/WebKit/Source/core/page/ChromeClient.h

index f6a5b080f18a4a94c7657da0135112bc37bf916e..7a68ae01e432d5a4b8164a2eed9dc05e7d4efdf5 100644

--- a/third_party/WebKit/Source/core/page/ChromeClient.h

+++ b/third_party/WebKit/Source/core/page/ChromeClient.h

@@ -85,8 +85,8 @@ public:

// The specified rectangle is adjusted for the minimum window size and the

// screen, then setWindowRect with the adjusted rectangle is called.

- void setWindowRectWithAdjustment(const IntRect&);

- virtual IntRect windowRect() = 0;

+ void setWindowRectWithAdjustment(const IntRect&, LocalFrame*);

+ virtual IntRect rootWindowRect() = 0;

virtual IntRect pageRect() = 0;

@@ -288,7 +288,7 @@ protected:

~ChromeClient() override { }

virtual void showMouseOverURL(const HitTestResult&) = 0;

- virtual void setWindowRect(const IntRect&) = 0;

+ virtual void setWindowRect(const IntRect&, LocalFrame*) = 0;

virtual bool openBeforeUnloadConfirmPanelDelegate(LocalFrame*, bool isReload) = 0;

virtual bool openJavaScriptAlertDelegate(LocalFrame*, const String&) = 0;

virtual bool openJavaScriptConfirmDelegate(LocalFrame*, const String&) = 0;