Issue 217733002: Support user-configurable function to create IDWriteFactory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 217733002: Support user-configurable function to create IDWriteFactory (Closed)

Created:
6 years, 9 months ago by scottmg

Modified:
6 years, 8 months ago

Reviewers:
bungeman-skia, reed1

CC:
skia-review_googlegroups.com, jschuh, cpu_(ooo_6.6-7.5)

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

Support user-configurable function to create IDWriteFactory Chromium can use Skia code to do warmup then and remove some duplicated code. Also allows experimenting with SHARED vs. ISOLATED mode. R=bungeman@google.com,reed@google.com BUG=chromium:333029

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -0 lines)			Patch
	M	include/ports/SkTypeface_win.h	View		1 chunk	+6 lines, -0 lines	0 comments	Download
	M	src/utils/win/SkDWrite.cpp	View		1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

bungeman-skia

I'd like to avoid adding more globals if possible. I've created an alternative here https://codereview.chromium.org/218833005/ ...

6 years, 8 months ago (2014-03-31 17:58:39 UTC) #2

sgtm, closing.

Expand Messages | Collapse Messages