Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1052)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2177323002: Revert of Optimize JSON dump in telemetry. (Closed)

Created:
4 years, 5 months ago by rnephew (Reviews Here)
Modified:
4 years, 5 months ago
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Base URL:
git@github.com:catapult-project/catapult@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Revert of Optimize JSON dump in telemetry. (patchset #2 id:20001 of https://codereview.chromium.org/2174543002/ ) Reason for revert: https://github.com/catapult-project/catapult/issues/2535 Original issue's description: > Optimize JSON dump in telemetry. > > This change makes the JSON dump go much faster (change from about > 8.5s to about 1.4s for a 330000-event trace) > > BUG=chromium:624164 > > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/07aa51b63e8c04002a8696e63beacff9a8f2fbfc TBR=aschulman@chromium.org,charliea@chromium.org,sullivan@chromium.org,zhenw@chromium.org,nednguyen@google.com,alexandermont@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:624164 BUG=catapult:#2535 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/189c4816b0330273e7648bcde4814796c1f5cef4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M telemetry/telemetry/value/trace.py View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
rnephew (Reviews Here)
Created Revert of Optimize JSON dump in telemetry.
4 years, 5 months ago (2016-07-25 17:48:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2177323002/1
4 years, 5 months ago (2016-07-25 17:48:57 UTC) #3
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 18:11:49 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698