Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2177283007: MD Settings: make .{primary,secondary,tertiary}-button selectors less specific (Closed)

Created:
4 years, 4 months ago by Dan Beam
Modified:
4 years, 4 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: make .{primary,secondary,tertiary}-button selectors less specific This is so theyll work with other tag names (i.e. <controlled-button>), not just <paper-button>. R=stevenjb@chromium.org BUG=614265 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/78bc682de08a15933cdbe62f724c804dbb493eb8 Cr-Commit-Position: refs/heads/master@{#408105}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M chrome/browser/resources/settings/settings_shared_css.html View 4 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Dan Beam
4 years, 4 months ago (2016-07-26 22:35:05 UTC) #2
stevenjb
lgtm
4 years, 4 months ago (2016-07-26 23:09:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2177283007/1
4 years, 4 months ago (2016-07-27 13:00:13 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-27 13:03:41 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 13:05:54 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/78bc682de08a15933cdbe62f724c804dbb493eb8
Cr-Commit-Position: refs/heads/master@{#408105}

Powered by Google App Engine
This is Rietveld 408576698