third_party/WebKit/LayoutTests/http/tests/serviceworker/opaque-response-in-memorycache.html - Issue 2177283006: Do not reuse opaque Resource from a service worker for non no-cors requests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/serviceworker/opaque-response-in-memorycache.html

Issue 2177283006: Do not reuse opaque Resource from a service worker for non no-cors requests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add tests, reflect comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/opaque-response-in-memorycache-iframe.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/serviceworker/opaque-response-in-memorycache.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/serviceworker/respond-with-response-body-with-invalid-chunk.html b/third_party/WebKit/LayoutTests/http/tests/serviceworker/opaque-response-in-memorycache.html

similarity index 75%

copy from third_party/WebKit/LayoutTests/http/tests/serviceworker/respond-with-response-body-with-invalid-chunk.html

copy to third_party/WebKit/LayoutTests/http/tests/serviceworker/opaque-response-in-memorycache.html

index 075c48acf6c188b08342ffc2bf7293a0f11da0e1..a723e241ebcaabc11a3d5df742ae831ccc2d13a8 100644

--- a/third_party/WebKit/LayoutTests/http/tests/serviceworker/respond-with-response-body-with-invalid-chunk.html

+++ b/third_party/WebKit/LayoutTests/http/tests/serviceworker/opaque-response-in-memorycache.html

@@ -1,14 +1,14 @@

<!DOCTYPE html>

-<title>respondWith with response body having invalid chunks</title>

+<title>Opaque responses on MemoryCache should not be reused for XHRs</title>

const WORKER =

- 'resources/respond-with-response-body-with-invalid-chunk-worker.js';

+ 'resources/opaque-response-in-memorycache-worker.js';

const SCOPE =

- 'resources/respond-with-response-body-with-invalid-chunk-iframe.html';

+ 'resources/opaque-response-in-memorycache-iframe.html';

var resolve_done;

var done_was_called = new Promise(resolve => resolve_done = resolve);

// Called by the iframe when done.

@@ -26,5 +26,5 @@ promise_test(t => {

.then(() => with_iframe(SCOPE))

.then(() => done_was_called)

.then(result => assert_equals(result, 'PASS'));

- }, 'Response with a ReadableStream having non-Uint8Array chunks should be transferred as errored');

+ }, 'Opaque responses on MemoryCache should not be reused for XHRs');

</script>