src/code-factory.cc - Issue 2177273002: Make FastNewFunctionContextStub take slots parameter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/code-factory.cc

Issue 2177273002: Make FastNewFunctionContextStub take slots parameter (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: comment and shift Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/code-factory.cc

diff --git a/src/code-factory.cc b/src/code-factory.cc

index 483948c45b34b222db3e778f19a1bbc8ba36b295..e99cff351882b12120c686fbde89a981642e2f76 100644

--- a/src/code-factory.cc

+++ b/src/code-factory.cc

@@ -471,8 +471,8 @@ Callable CodeFactory::FastCloneShallowObject(Isolate* isolate, int length) {

// static

-Callable CodeFactory::FastNewContext(Isolate* isolate, int slot_count) {

- FastNewFunctionContextStub stub(isolate, slot_count);

+Callable CodeFactory::FastNewContext(Isolate* isolate) {

Benedikt Meurer 2016/07/29 03:29:16 Nit: Please rename the factory method to FastNewFu

klaasb 2016/07/29 09:51:36 Done.

+ FastNewFunctionContextStub stub(isolate);

return Callable(stub.GetCode(), stub.GetCallInterfaceDescriptor());

}

« no previous file with comments | « src/code-factory.h ('k') | src/code-stubs.h » ('j') | src/code-stubs.cc » ('J')