src/crankshaft/x64/lithium-codegen-x64.cc - Issue 2177273002: Make FastNewFunctionContextStub take slots parameter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/crankshaft/x64/lithium-codegen-x64.cc

Issue 2177273002: Make FastNewFunctionContextStub take slots parameter (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: move loop check Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/crankshaft/x64/lithium-codegen-x64.cc

diff --git a/src/crankshaft/x64/lithium-codegen-x64.cc b/src/crankshaft/x64/lithium-codegen-x64.cc

index b0c10add4f3115cad40365ed4e172e95b6d4b21b..791be9d2f0af17265762292e6bfe08c330c01bb9 100644

--- a/src/crankshaft/x64/lithium-codegen-x64.cc

+++ b/src/crankshaft/x64/lithium-codegen-x64.cc

@@ -182,7 +182,8 @@ void LCodeGen::DoPrologue(LPrologue* instr) {

__ CallRuntime(Runtime::kNewScriptContext);

deopt_mode = Safepoint::kLazyDeopt;

} else if (slots <= FastNewFunctionContextStub::kMaximumSlots) {

- FastNewFunctionContextStub stub(isolate(), slots);

+ FastNewFunctionContextStub stub(isolate());

+ __ Set(FastNewFunctionContextDescriptor::SlotsRegister(), slots);

__ CallStub(&stub);

// Result of FastNewFunctionContextStub is always in new space.

need_write_barrier = false;