src/compiler/js-generic-lowering.cc - Issue 2177273002: Make FastNewFunctionContextStub take slots parameter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/js-generic-lowering.cc

Issue 2177273002: Make FastNewFunctionContextStub take slots parameter (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: move loop check Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/js-generic-lowering.cc

diff --git a/src/compiler/js-generic-lowering.cc b/src/compiler/js-generic-lowering.cc

index ac64f460f29ad4b7f492a71554ce6333b0fb321c..bf939a9295f457e07261f56ed659f6b55f0016e2 100644

--- a/src/compiler/js-generic-lowering.cc

+++ b/src/compiler/js-generic-lowering.cc

@@ -428,7 +428,8 @@ void JSGenericLowering::LowerJSCreateFunctionContext(Node* node) {

// Use the FastNewFunctionContextStub only for function contexts up maximum

// size.

if (slot_count <= FastNewFunctionContextStub::kMaximumSlots) {

- Callable callable = CodeFactory::FastNewContext(isolate(), slot_count);

+ Callable callable = CodeFactory::FastNewContext(isolate());

+ node->InsertInput(zone(), 1, jsgraph()->Int32Constant(slot_count));

ReplaceWithStubCall(node, callable, flags);

} else {

ReplaceWithRuntimeCall(node, Runtime::kNewFunctionContext);