src/full-codegen/ia32/full-codegen-ia32.cc - Issue 2177273002: Make FastNewFunctionContextStub take slots parameter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/ia32/full-codegen-ia32.cc

Issue 2177273002: Make FastNewFunctionContextStub take slots parameter (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: fix arm{,64},mips{,64} and remove ppc,s390,x87 again Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen/ia32/full-codegen-ia32.cc

diff --git a/src/full-codegen/ia32/full-codegen-ia32.cc b/src/full-codegen/ia32/full-codegen-ia32.cc

index 383b83605eabfe7c7cc32ccfa05fafd7a40e05f2..a4c749ea72b9c55747241e8b5258fd03d2cb8441 100644

--- a/src/full-codegen/ia32/full-codegen-ia32.cc

+++ b/src/full-codegen/ia32/full-codegen-ia32.cc

@@ -177,7 +177,9 @@ void FullCodeGenerator::Generate() {

__ push(edx); // Preserve new target.

}

if (slots <= FastNewFunctionContextStub::kMaximumSlots) {

- FastNewFunctionContextStub stub(isolate(), slots);

+ FastNewFunctionContextStub stub(isolate());

+ __ mov(FastNewFunctionContextDescriptor::SlotsRegister(),

+ Immediate(slots));

__ CallStub(&stub);

// Result of FastNewFunctionContextStub is always in new space.

need_write_barrier = false;