Make FastNewFunctionContextStub take slots parameter

src/code-stubs.h

Index: src/code-stubs.h
diff --git a/src/code-stubs.h b/src/code-stubs.h
index 05d4a0be792aab3c8121f15faf97e20f47543495..06376a8b150339183795ca28c2c372410ac90f11 100644
--- a/src/code-stubs.h
+++ b/src/code-stubs.h
@@ -1060,13 +1060,8 @@ class FastNewFunctionContextStub final : public TurboFanCodeStub {
  public:
   static const int kMaximumSlots = 64;

[klaasb, 2016/07/26 17:04:52]

I'm unsure whether/why we need to still limit this?
From here:
https://chromium.googlesource.com/v8/v8/+/013860d42efb102403207f9a1d9688509d3...
I can see that the original motivation was to limit the amount of code stubs but
with this change there will ever be only one. Get rid of it and all related
lines that branch on it and otherwise call the runtime?

[rmcilroy, 2016/07/27 11:11:39]

Sounds reasonable to me, any reason why not to do this Benedikt?

[Benedikt Meurer, 2016/08/01 17:35:08]

Makes sense. Please do that.

 
-  FastNewFunctionContextStub(Isolate* isolate, int slots)
-      : TurboFanCodeStub(isolate) {
-    DCHECK(slots >= 0 && slots <= kMaximumSlots);
-    minor_key_ = SlotsBits::encode(slots);
-  }
-
-  int slots() const { return SlotsBits::decode(minor_key_); }
+  explicit FastNewFunctionContextStub(Isolate* isolate)
+      : TurboFanCodeStub(isolate) {}
 
  private:
   class SlotsBits : public BitField<int, 0, 8> {};

[rmcilroy, 2016/07/27 11:11:38]

You can delete the SlotBits class now too. 

[klaasb, 2016/07/27 17:06:31]

Done.