Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Side by Side Diff: src/full-codegen/x64/full-codegen-x64.cc

Issue 2177273002: Make FastNewFunctionContextStub take slots parameter (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: comment and shift Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_X64 5 #if V8_TARGET_ARCH_X64
6 6
7 #include "src/ast/scopes.h" 7 #include "src/ast/scopes.h"
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 157 matching lines...) Expand 10 before | Expand all | Expand 10 after
168 __ CallRuntime(Runtime::kNewScriptContext); 168 __ CallRuntime(Runtime::kNewScriptContext);
169 PrepareForBailoutForId(BailoutId::ScriptContext(), 169 PrepareForBailoutForId(BailoutId::ScriptContext(),
170 BailoutState::TOS_REGISTER); 170 BailoutState::TOS_REGISTER);
171 // The new target value is not used, clobbering is safe. 171 // The new target value is not used, clobbering is safe.
172 DCHECK_NULL(info->scope()->new_target_var()); 172 DCHECK_NULL(info->scope()->new_target_var());
173 } else { 173 } else {
174 if (info->scope()->new_target_var() != nullptr) { 174 if (info->scope()->new_target_var() != nullptr) {
175 __ Push(rdx); // Preserve new target. 175 __ Push(rdx); // Preserve new target.
176 } 176 }
177 if (slots <= FastNewFunctionContextStub::kMaximumSlots) { 177 if (slots <= FastNewFunctionContextStub::kMaximumSlots) {
178 FastNewFunctionContextStub stub(isolate(), slots); 178 FastNewFunctionContextStub stub(isolate());
179 __ Set(FastNewFunctionContextDescriptor::SlotsRegister(), slots);
179 __ CallStub(&stub); 180 __ CallStub(&stub);
180 // Result of FastNewFunctionContextStub is always in new space. 181 // Result of FastNewFunctionContextStub is always in new space.
181 need_write_barrier = false; 182 need_write_barrier = false;
182 } else { 183 } else {
183 __ Push(rdi); 184 __ Push(rdi);
184 __ CallRuntime(Runtime::kNewFunctionContext); 185 __ CallRuntime(Runtime::kNewFunctionContext);
185 } 186 }
186 if (info->scope()->new_target_var() != nullptr) { 187 if (info->scope()->new_target_var() != nullptr) {
187 __ Pop(rdx); // Restore new target. 188 __ Pop(rdx); // Restore new target.
188 } 189 }
(...skipping 3473 matching lines...) Expand 10 before | Expand all | Expand 10 after
3662 DCHECK_EQ( 3663 DCHECK_EQ(
3663 isolate->builtins()->OnStackReplacement()->entry(), 3664 isolate->builtins()->OnStackReplacement()->entry(),
3664 Assembler::target_address_at(call_target_address, unoptimized_code)); 3665 Assembler::target_address_at(call_target_address, unoptimized_code));
3665 return ON_STACK_REPLACEMENT; 3666 return ON_STACK_REPLACEMENT;
3666 } 3667 }
3667 3668
3668 } // namespace internal 3669 } // namespace internal
3669 } // namespace v8 3670 } // namespace v8
3670 3671
3671 #endif // V8_TARGET_ARCH_X64 3672 #endif // V8_TARGET_ARCH_X64
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698