Issue 2177243004: [merge to m53] Fix getComputedStyle for non-box-layout elements

Issue 2177243004: [merge to m53] Fix getComputedStyle for non-box-layout elements (Closed)

Created:
4 years, 4 months ago by Greg K

Modified:
4 years, 4 months ago

Reviewers:
mstensho (USE GERRIT)

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2785

Target Ref:
refs/pending/branch-heads/2785

Project:
chromium

Visibility:
Public.

[merge to m53] Fix getComputedStyle for non-box-layout elements This fixes a crash introduced by https://codereview.chromium.org/1826423003/ Code that treated a layout object as a Box layout were not properly guarded by isBox. This caused a crash when calling getComputedStyle on positioned non-box elements, e.g. <ruby>. R=mstensho@opera.com BUG=610986 Review-Url: https://codereview.chromium.org/2102843002 Cr-Commit-Position: refs/heads/master@{#404336} (cherry picked from commit 86d16a615d6e9abf6d991f430b496c26a4271d10) Committed: https://chromium.googlesource.com/chromium/src/+/77bd3be00df2154feecd4b13e1acced865a286e8

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+94 lines, -8 lines)			Patch
M	third_party/WebKit/LayoutTests/fast/css/getComputedStyle/getComputedStyle-resolved-values.html	View	3 chunks	+9 lines, -0 lines	0 comments	Download
M	third_party/WebKit/LayoutTests/fast/css/getComputedStyle/getComputedStyle-resolved-values-expected.txt	View	2 chunks	+70 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp	View	1 chunk	+15 lines, -8 lines	0 comments	Download

Total messages: 2 (1 generated)

Greg K

4 years, 4 months ago (2016-07-25 23:59:48 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
77bd3be00df2154feecd4b13e1acced865a286e8.