Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Unified Diff: third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp

Issue 2177243002: Use per-frame TaskRunner instead of thread's default in DataConsumerHandle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@data_consumer_handle_unique_ptr
Patch Set: update Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp
diff --git a/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp b/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp
index ff39381267a7782827829431a53b43ba753b8c95..70cc950632ed496e3892c5832892cd5b9fcdae41 100644
--- a/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp
+++ b/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp
@@ -67,9 +67,10 @@ class EmptyDataHandle final : public WebDataConsumerHandle {
private:
class EmptyDataReader final : public WebDataConsumerHandle::Reader {
public:
- explicit EmptyDataReader(WebDataConsumerHandle::Client* client) : m_factory(this)
+ explicit EmptyDataReader(WebDataConsumerHandle::Client* client, std::unique_ptr<WebTaskRunner> readerTaskRunner) : m_factory(this)
{
- Platform::current()->currentThread()->getWebTaskRunner()->postTask(BLINK_FROM_HERE, WTF::bind(&EmptyDataReader::notify, m_factory.createWeakPtr(), WTF::unretained(client)));
+ DCHECK(readerTaskRunner->runsTasksOnCurrentThread());
+ readerTaskRunner->postTask(BLINK_FROM_HERE, WTF::bind(&EmptyDataReader::notify, m_factory.createWeakPtr(), WTF::unretained(client)));
}
private:
Result beginRead(const void** buffer, WebDataConsumerHandle::Flags, size_t *available) override
@@ -89,9 +90,9 @@ private:
WeakPtrFactory<EmptyDataReader> m_factory;
};
- std::unique_ptr<Reader> obtainReader(Client* client) override
+ std::unique_ptr<Reader> obtainReader(Client* client, std::unique_ptr<WebTaskRunner> readerTaskRunner) override
{
- return WTF::wrapUnique(new EmptyDataReader(client));
+ return WTF::wrapUnique(new EmptyDataReader(client, std::move(readerTaskRunner)));
}
const char* debugName() const override { return "EmptyDataHandle"; }
};

Powered by Google App Engine
This is Rietveld 408576698