third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp - Issue 2177243002: Use per-frame TaskRunner instead of thread's default in DataConsumerHandle

Unified Diff: third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp

Issue 2177243002: Use per-frame TaskRunner instead of thread's default in DataConsumerHandle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@data_consumer_handle_unique_ptr

Patch Set: update Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/child/web_data_consumer_handle_impl.cc ('K') | « third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp ('k') | third_party/WebKit/Source/modules/fetch/CompositeDataConsumerHandle.cpp » ('j') | third_party/WebKit/public/platform/WebDataConsumerHandle.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp

diff --git a/third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp b/third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp

index 83ed30bdb9ff5e88d498b5891ee5e391124a9384..21838ea0c1f31685a16064675caf5a2e1cf5de9b 100644

--- a/third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp

+++ b/third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp

@@ -77,6 +77,10 @@ TEST_F(BodyStreamBufferTest, Tee)

MockFetchDataLoaderClient* client1 = MockFetchDataLoaderClient::create();

MockFetchDataLoaderClient* client2 = MockFetchDataLoaderClient::create();

+ WebTaskRunner* taskRunner = Platform::current()->currentThread()->getWebTaskRunner();

+ EXPECT_CALL(*client1, getTaskRunner()).WillRepeatedly(Return(taskRunner));

+ EXPECT_CALL(*client2, getTaskRunner()).WillRepeatedly(Return(taskRunner));

InSequence s;

EXPECT_CALL(checkpoint, Call(1));

EXPECT_CALL(*client1, didFetchDataLoadedString(String("hello, world")));

@@ -286,6 +290,9 @@ TEST_F(BodyStreamBufferTest, LoadBodyStreamBufferAsArrayBuffer)

MockFetchDataLoaderClient* client = MockFetchDataLoaderClient::create();

DOMArrayBuffer* arrayBuffer = nullptr;

+ WebTaskRunner* taskRunner = Platform::current()->currentThread()->getWebTaskRunner();

+ EXPECT_CALL(*client, getTaskRunner()).WillRepeatedly(Return(taskRunner));

InSequence s;

EXPECT_CALL(checkpoint, Call(1));

EXPECT_CALL(*client, didFetchDataLoadedArrayBufferMock(_)).WillOnce(SaveArg<0>(&arrayBuffer));

@@ -319,6 +326,9 @@ TEST_F(BodyStreamBufferTest, LoadBodyStreamBufferAsBlob)

MockFetchDataLoaderClient* client = MockFetchDataLoaderClient::create();

RefPtr<BlobDataHandle> blobDataHandle;

+ WebTaskRunner* taskRunner = Platform::current()->currentThread()->getWebTaskRunner();

+ EXPECT_CALL(*client, getTaskRunner()).WillRepeatedly(Return(taskRunner));

InSequence s;

EXPECT_CALL(checkpoint, Call(1));

EXPECT_CALL(*client, didFetchDataLoadedBlobHandleMock(_)).WillOnce(SaveArg<0>(&blobDataHandle));

@@ -350,6 +360,9 @@ TEST_F(BodyStreamBufferTest, LoadBodyStreamBufferAsString)

Checkpoint checkpoint;

MockFetchDataLoaderClient* client = MockFetchDataLoaderClient::create();

+ WebTaskRunner* taskRunner = Platform::current()->currentThread()->getWebTaskRunner();

+ EXPECT_CALL(*client, getTaskRunner()).WillRepeatedly(Return(taskRunner));

InSequence s;

EXPECT_CALL(checkpoint, Call(1));

EXPECT_CALL(*client, didFetchDataLoadedString(String("hello")));

@@ -380,6 +393,9 @@ TEST_F(BodyStreamBufferTest, LoadClosedHandle)

Checkpoint checkpoint;

MockFetchDataLoaderClient* client = MockFetchDataLoaderClient::create();

+ WebTaskRunner* taskRunner = Platform::current()->currentThread()->getWebTaskRunner();

+ EXPECT_CALL(*client, getTaskRunner()).WillRepeatedly(Return(taskRunner));

InSequence s;

EXPECT_CALL(checkpoint, Call(1));

EXPECT_CALL(*client, didFetchDataLoadedString(String("")));

@@ -415,6 +431,9 @@ TEST_F(BodyStreamBufferTest, LoadErroredHandle)

Checkpoint checkpoint;

MockFetchDataLoaderClient* client = MockFetchDataLoaderClient::create();

+ WebTaskRunner* taskRunner = Platform::current()->currentThread()->getWebTaskRunner();

+ EXPECT_CALL(*client, getTaskRunner()).WillRepeatedly(Return(taskRunner));

InSequence s;

EXPECT_CALL(checkpoint, Call(1));

EXPECT_CALL(*client, didFetchDataLoadFailed());

@@ -448,6 +467,8 @@ TEST_F(BodyStreamBufferTest, LoaderShouldBeKeptAliveByBodyStreamBuffer)

V8TestingScope scope;

Checkpoint checkpoint;

MockFetchDataLoaderClient* client = MockFetchDataLoaderClient::create();

+ WebTaskRunner* taskRunner = Platform::current()->currentThread()->getWebTaskRunner();

+ EXPECT_CALL(*client, getTaskRunner()).WillRepeatedly(Return(taskRunner));

InSequence s;

EXPECT_CALL(checkpoint, Call(1));