Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2380)

Unified Diff: content/child/shared_memory_data_consumer_handle_unittest.cc

Issue 2177243002: Use per-frame TaskRunner instead of thread's default in DataConsumerHandle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@data_consumer_handle_unique_ptr
Patch Set: update Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/shared_memory_data_consumer_handle_unittest.cc
diff --git a/content/child/shared_memory_data_consumer_handle_unittest.cc b/content/child/shared_memory_data_consumer_handle_unittest.cc
index fae896cf12acec41cdce3c5e1148d6ca0e092f90..ec3c5e7b607dbadcc832e5dde200f3adf7e4115f 100644
--- a/content/child/shared_memory_data_consumer_handle_unittest.cc
+++ b/content/child/shared_memory_data_consumer_handle_unittest.cc
@@ -25,6 +25,7 @@
#include "content/public/child/fixed_received_data.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
+#include "third_party/WebKit/public/platform/WebTaskRunner.h"
namespace content {
@@ -111,6 +112,7 @@ class DestructionTrackingFunction
class MockClient : public WebDataConsumerHandle::Client {
public:
MOCK_METHOD0(didGetReadable, void());
+ MOCK_METHOD0(getTaskRunner, blink::WebTaskRunner*());
};
std::string ToString(const void* p, size_t size) {
@@ -126,6 +128,9 @@ class ThreadedSharedMemoryDataConsumerHandleTest : public ::testing::Test {
explicit ClientImpl(ReadDataOperation* operation) : operation_(operation) {}
void didGetReadable() override { operation_->ReadData(); }
+ blink::WebTaskRunner* getTaskRunner() override {
+ return nullptr;
+ }
private:
ReadDataOperation* operation_;
@@ -187,6 +192,7 @@ class ThreadedSharedMemoryDataConsumerHandleTest : public ::testing::Test {
void SetUp() override {
handle_.reset(
new SharedMemoryDataConsumerHandle(kApplyBackpressure, &writer_));
+ EXPECT_CALL(client_, getTaskRunner()).WillRepeatedly(Return(nullptr));
}
StrictMock<MockClient> client_;
@@ -200,6 +206,7 @@ class SharedMemoryDataConsumerHandleTest
protected:
void SetUp() override {
handle_.reset(new SharedMemoryDataConsumerHandle(GetParam(), &writer_));
+ EXPECT_CALL(client_, getTaskRunner()).WillRepeatedly(Return(nullptr));
}
std::unique_ptr<FixedReceivedData> NewFixedData(const char* s) {
auto size = strlen(s);

Powered by Google App Engine
This is Rietveld 408576698