Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Side by Side Diff: third_party/WebKit/Source/modules/fetch/DataConsumerHandleUtilTest.cpp

Issue 2177243002: Use per-frame TaskRunner instead of thread's default in DataConsumerHandle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@data_consumer_handle_unique_ptr
Patch Set: update Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "modules/fetch/DataConsumerHandleUtil.h" 5 #include "modules/fetch/DataConsumerHandleUtil.h"
6 6
7 #include "modules/fetch/DataConsumerHandleTestUtil.h" 7 #include "modules/fetch/DataConsumerHandleTestUtil.h"
8 #include <memory> 8 #include <memory>
9 9
10 namespace blink { 10 namespace blink {
11 11
12 namespace { 12 namespace {
13 13
14 const WebDataConsumerHandle::Result kShouldWait = WebDataConsumerHandle::ShouldW ait; 14 const WebDataConsumerHandle::Result kShouldWait = WebDataConsumerHandle::ShouldW ait;
15 const WebDataConsumerHandle::Result kDone = WebDataConsumerHandle::Done; 15 const WebDataConsumerHandle::Result kDone = WebDataConsumerHandle::Done;
16 const WebDataConsumerHandle::Result kUnexpectedError = WebDataConsumerHandle::Un expectedError; 16 const WebDataConsumerHandle::Result kUnexpectedError = WebDataConsumerHandle::Un expectedError;
17 const WebDataConsumerHandle::Flags kNone = WebDataConsumerHandle::FlagNone; 17 const WebDataConsumerHandle::Flags kNone = WebDataConsumerHandle::FlagNone;
18 18
19 TEST(DataConsumerHandleUtilTest, CreateWaitingHandle) 19 TEST(DataConsumerHandleUtilTest, CreateWaitingHandle)
20 { 20 {
21 char buffer[20]; 21 char buffer[20];
22 const void* p = nullptr; 22 const void* p = nullptr;
23 size_t size = 0; 23 size_t size = 0;
24 std::unique_ptr<WebDataConsumerHandle> handle = createWaitingDataConsumerHan dle(); 24 std::unique_ptr<WebDataConsumerHandle> handle = createWaitingDataConsumerHan dle();
25 std::unique_ptr<WebDataConsumerHandle::Reader> reader = handle->obtainReader (nullptr); 25 std::unique_ptr<WebDataConsumerHandle::Reader> reader = handle->obtainReader (nullptr, getCurrentTaskRunner());
26 26
27 EXPECT_EQ(kShouldWait, reader->read(buffer, sizeof(buffer), kNone, &size)); 27 EXPECT_EQ(kShouldWait, reader->read(buffer, sizeof(buffer), kNone, &size));
28 EXPECT_EQ(kShouldWait, reader->beginRead(&p, kNone, &size)); 28 EXPECT_EQ(kShouldWait, reader->beginRead(&p, kNone, &size));
29 EXPECT_EQ(kUnexpectedError, reader->endRead(99)); 29 EXPECT_EQ(kUnexpectedError, reader->endRead(99));
30 } 30 }
31 31
32 TEST(DataConsumerHandleUtilTest, WaitingHandleNoNotification) 32 TEST(DataConsumerHandleUtilTest, WaitingHandleNoNotification)
33 { 33 {
34 RefPtr<DataConsumerHandleTestUtil::ThreadingHandleNoNotificationTest> test = DataConsumerHandleTestUtil::ThreadingHandleNoNotificationTest::create(); 34 RefPtr<DataConsumerHandleTestUtil::ThreadingHandleNoNotificationTest> test = DataConsumerHandleTestUtil::ThreadingHandleNoNotificationTest::create();
35 // Test this function doesn't crash. 35 // Test this function doesn't crash.
36 test->run(createWaitingDataConsumerHandle()); 36 test->run(createWaitingDataConsumerHandle());
37 } 37 }
38 38
39 TEST(DataConsumerHandleUtilTest, CreateDoneHandle) 39 TEST(DataConsumerHandleUtilTest, CreateDoneHandle)
40 { 40 {
41 char buffer[20]; 41 char buffer[20];
42 const void* p = nullptr; 42 const void* p = nullptr;
43 size_t size = 0; 43 size_t size = 0;
44 std::unique_ptr<WebDataConsumerHandle> handle = createDoneDataConsumerHandle (); 44 std::unique_ptr<WebDataConsumerHandle> handle = createDoneDataConsumerHandle ();
45 std::unique_ptr<WebDataConsumerHandle::Reader> reader = handle->obtainReader (nullptr); 45 std::unique_ptr<WebDataConsumerHandle::Reader> reader = handle->obtainReader (nullptr, getCurrentTaskRunner());
46 46
47 EXPECT_EQ(kDone, reader->read(buffer, sizeof(buffer), kNone, &size)); 47 EXPECT_EQ(kDone, reader->read(buffer, sizeof(buffer), kNone, &size));
48 EXPECT_EQ(kDone, reader->beginRead(&p, kNone, &size)); 48 EXPECT_EQ(kDone, reader->beginRead(&p, kNone, &size));
49 EXPECT_EQ(kUnexpectedError, reader->endRead(99)); 49 EXPECT_EQ(kUnexpectedError, reader->endRead(99));
50 } 50 }
51 51
52 TEST(DataConsumerHandleUtilTest, DoneHandleNotification) 52 TEST(DataConsumerHandleUtilTest, DoneHandleNotification)
53 { 53 {
54 RefPtr<DataConsumerHandleTestUtil::ThreadingHandleNotificationTest> test = D ataConsumerHandleTestUtil::ThreadingHandleNotificationTest::create(); 54 RefPtr<DataConsumerHandleTestUtil::ThreadingHandleNotificationTest> test = D ataConsumerHandleTestUtil::ThreadingHandleNotificationTest::create();
55 // Test this function returns. 55 // Test this function returns.
56 test->run(createDoneDataConsumerHandle()); 56 test->run(createDoneDataConsumerHandle());
57 } 57 }
58 58
59 TEST(DataConsumerHandleUtilTest, DoneHandleNoNotification) 59 TEST(DataConsumerHandleUtilTest, DoneHandleNoNotification)
60 { 60 {
61 RefPtr<DataConsumerHandleTestUtil::ThreadingHandleNoNotificationTest> test = DataConsumerHandleTestUtil::ThreadingHandleNoNotificationTest::create(); 61 RefPtr<DataConsumerHandleTestUtil::ThreadingHandleNoNotificationTest> test = DataConsumerHandleTestUtil::ThreadingHandleNoNotificationTest::create();
62 // Test this function doesn't crash. 62 // Test this function doesn't crash.
63 test->run(createDoneDataConsumerHandle()); 63 test->run(createDoneDataConsumerHandle());
64 } 64 }
65 65
66 TEST(DataConsumerHandleUtilTest, CreateUnexpectedErrorHandle) 66 TEST(DataConsumerHandleUtilTest, CreateUnexpectedErrorHandle)
67 { 67 {
68 char buffer[20]; 68 char buffer[20];
69 const void* p = nullptr; 69 const void* p = nullptr;
70 size_t size = 0; 70 size_t size = 0;
71 std::unique_ptr<WebDataConsumerHandle> handle = createUnexpectedErrorDataCon sumerHandle(); 71 std::unique_ptr<WebDataConsumerHandle> handle = createUnexpectedErrorDataCon sumerHandle();
72 std::unique_ptr<WebDataConsumerHandle::Reader> reader = handle->obtainReader (nullptr); 72 std::unique_ptr<WebDataConsumerHandle::Reader> reader = handle->obtainReader (nullptr, getCurrentTaskRunner());
73 73
74 EXPECT_EQ(kUnexpectedError, reader->read(buffer, sizeof(buffer), kNone, &siz e)); 74 EXPECT_EQ(kUnexpectedError, reader->read(buffer, sizeof(buffer), kNone, &siz e));
75 EXPECT_EQ(kUnexpectedError, reader->beginRead(&p, kNone, &size)); 75 EXPECT_EQ(kUnexpectedError, reader->beginRead(&p, kNone, &size));
76 EXPECT_EQ(kUnexpectedError, reader->endRead(99)); 76 EXPECT_EQ(kUnexpectedError, reader->endRead(99));
77 } 77 }
78 78
79 TEST(DataConsumerHandleUtilTest, UnexpectedErrorHandleNotification) 79 TEST(DataConsumerHandleUtilTest, UnexpectedErrorHandleNotification)
80 { 80 {
81 RefPtr<DataConsumerHandleTestUtil::ThreadingHandleNotificationTest> test = D ataConsumerHandleTestUtil::ThreadingHandleNotificationTest::create(); 81 RefPtr<DataConsumerHandleTestUtil::ThreadingHandleNotificationTest> test = D ataConsumerHandleTestUtil::ThreadingHandleNotificationTest::create();
82 // Test this function returns. 82 // Test this function returns.
83 test->run(createUnexpectedErrorDataConsumerHandle()); 83 test->run(createUnexpectedErrorDataConsumerHandle());
84 } 84 }
85 85
86 TEST(DataConsumerHandleUtilTest, UnexpectedErrorHandleNoNotification) 86 TEST(DataConsumerHandleUtilTest, UnexpectedErrorHandleNoNotification)
87 { 87 {
88 RefPtr<DataConsumerHandleTestUtil::ThreadingHandleNoNotificationTest> test = DataConsumerHandleTestUtil::ThreadingHandleNoNotificationTest::create(); 88 RefPtr<DataConsumerHandleTestUtil::ThreadingHandleNoNotificationTest> test = DataConsumerHandleTestUtil::ThreadingHandleNoNotificationTest::create();
89 // Test this function doesn't crash. 89 // Test this function doesn't crash.
90 test->run(createUnexpectedErrorDataConsumerHandle()); 90 test->run(createUnexpectedErrorDataConsumerHandle());
91 } 91 }
92 92
93 } // namespace 93 } // namespace
94 94
95 } // namespace blink 95 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698