Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Side by Side Diff: third_party/WebKit/Source/modules/fetch/DataConsumerHandleUtil.cpp

Issue 2177243002: Use per-frame TaskRunner instead of thread's default in DataConsumerHandle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@data_consumer_handle_unique_ptr
Patch Set: update Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "modules/fetch/DataConsumerHandleUtil.h" 5 #include "modules/fetch/DataConsumerHandleUtil.h"
6 6
7 #include "platform/blob/BlobData.h" 7 #include "platform/blob/BlobData.h"
8 #include "public/platform/Platform.h" 8 #include "public/platform/Platform.h"
9 #include "public/platform/WebTaskRunner.h" 9 #include "public/platform/WebTaskRunner.h"
10 #include "public/platform/WebThread.h" 10 #include "public/platform/WebThread.h"
(...skipping 16 matching lines...) Expand all
27 { 27 {
28 *available = 0; 28 *available = 0;
29 *buffer = nullptr; 29 *buffer = nullptr;
30 return ShouldWait; 30 return ShouldWait;
31 } 31 }
32 Result endRead(size_t) override 32 Result endRead(size_t) override
33 { 33 {
34 return UnexpectedError; 34 return UnexpectedError;
35 } 35 }
36 }; 36 };
37 std::unique_ptr<Reader> obtainReader(Client*) override { return WTF::wrapUni que(new ReaderImpl); } 37 std::unique_ptr<Reader> obtainReader(Client*, std::unique_ptr<WebTaskRunner> ) override { return WTF::wrapUnique(new ReaderImpl); }
38 38
39 const char* debugName() const override { return "WaitingHandle"; } 39 const char* debugName() const override { return "WaitingHandle"; }
40 }; 40 };
41 41
42 class RepeatingReader final : public WebDataConsumerHandle::Reader { 42 class RepeatingReader final : public WebDataConsumerHandle::Reader {
43 public: 43 public:
44 explicit RepeatingReader(Result result, WebDataConsumerHandle::Client* clien t) : m_result(result), m_notifier(client) { } 44 explicit RepeatingReader(Result result, WebDataConsumerHandle::Client* clien t, std::unique_ptr<WebTaskRunner> readerTaskRunner)
45 : m_result(result)
46 , m_notifier(client, readerTaskRunner.get()) { }
45 47
46 private: 48 private:
47 Result beginRead(const void** buffer, WebDataConsumerHandle::Flags, size_t * available) override 49 Result beginRead(const void** buffer, WebDataConsumerHandle::Flags, size_t * available) override
48 { 50 {
49 *available = 0; 51 *available = 0;
50 *buffer = nullptr; 52 *buffer = nullptr;
51 return m_result; 53 return m_result;
52 } 54 }
53 Result endRead(size_t) override 55 Result endRead(size_t) override
54 { 56 {
55 return WebDataConsumerHandle::UnexpectedError; 57 return WebDataConsumerHandle::UnexpectedError;
56 } 58 }
57 59
58 Result m_result; 60 Result m_result;
59 NotifyOnReaderCreationHelper m_notifier; 61 NotifyOnReaderCreationHelper m_notifier;
60 }; 62 };
61 63
62 class DoneHandle final : public WebDataConsumerHandle { 64 class DoneHandle final : public WebDataConsumerHandle {
63 private: 65 private:
64 std::unique_ptr<Reader> obtainReader(Client* client) override { return WTF:: wrapUnique(new RepeatingReader(Done, client)); } 66 std::unique_ptr<Reader> obtainReader(Client* client, std::unique_ptr<WebTask Runner> readerTaskRunner) override
67 {
68 return WTF::wrapUnique(new RepeatingReader(Done, client, std::move(reade rTaskRunner)));
69 }
65 const char* debugName() const override { return "DoneHandle"; } 70 const char* debugName() const override { return "DoneHandle"; }
66 }; 71 };
67 72
68 class UnexpectedErrorHandle final : public WebDataConsumerHandle { 73 class UnexpectedErrorHandle final : public WebDataConsumerHandle {
69 private: 74 private:
70 std::unique_ptr<Reader> obtainReader(Client* client) override { return WTF:: wrapUnique(new RepeatingReader(UnexpectedError, client)); } 75 std::unique_ptr<Reader> obtainReader(Client* client, std::unique_ptr<WebTask Runner> readerTaskRunner) override
76 {
77 return WTF::wrapUnique(new RepeatingReader(UnexpectedError, client, std: :move(readerTaskRunner)));
78 }
71 const char* debugName() const override { return "UnexpectedErrorHandle"; } 79 const char* debugName() const override { return "UnexpectedErrorHandle"; }
72 }; 80 };
73 81
74 class WebToFetchDataConsumerHandleAdapter : public FetchDataConsumerHandle { 82 class WebToFetchDataConsumerHandleAdapter : public FetchDataConsumerHandle {
75 public: 83 public:
76 WebToFetchDataConsumerHandleAdapter(std::unique_ptr<WebDataConsumerHandle> h andle) : m_handle(std::move(handle)) { } 84 WebToFetchDataConsumerHandleAdapter(std::unique_ptr<WebDataConsumerHandle> h andle) : m_handle(std::move(handle)) { }
77 private: 85 private:
78 class ReaderImpl final : public FetchDataConsumerHandle::Reader { 86 class ReaderImpl final : public FetchDataConsumerHandle::Reader {
79 public: 87 public:
80 ReaderImpl(std::unique_ptr<WebDataConsumerHandle::Reader> reader) : m_re ader(std::move(reader)) { } 88 ReaderImpl(std::unique_ptr<WebDataConsumerHandle::Reader> reader) : m_re ader(std::move(reader)) { }
81 Result read(void* data, size_t size, Flags flags, size_t* readSize) over ride 89 Result read(void* data, size_t size, Flags flags, size_t* readSize) over ride
82 { 90 {
83 return m_reader->read(data, size, flags, readSize); 91 return m_reader->read(data, size, flags, readSize);
84 } 92 }
85 93
86 Result beginRead(const void** buffer, Flags flags, size_t* available) ov erride 94 Result beginRead(const void** buffer, Flags flags, size_t* available) ov erride
87 { 95 {
88 return m_reader->beginRead(buffer, flags, available); 96 return m_reader->beginRead(buffer, flags, available);
89 } 97 }
90 Result endRead(size_t readSize) override 98 Result endRead(size_t readSize) override
91 { 99 {
92 return m_reader->endRead(readSize); 100 return m_reader->endRead(readSize);
93 } 101 }
94 private: 102 private:
95 std::unique_ptr<WebDataConsumerHandle::Reader> m_reader; 103 std::unique_ptr<WebDataConsumerHandle::Reader> m_reader;
96 }; 104 };
97 105
98 std::unique_ptr<Reader> obtainFetchDataReader(Client* client) override 106 std::unique_ptr<Reader> obtainFetchDataReader(Client* client, std::unique_pt r<WebTaskRunner> readerTaskRunner) override
99 { 107 {
100 return WTF::wrapUnique(new ReaderImpl(m_handle->obtainReader(client))); 108 return WTF::wrapUnique(new ReaderImpl(m_handle->obtainReader(client, std ::move(readerTaskRunner))));
101 } 109 }
102 110
103 const char* debugName() const override { return m_handle->debugName(); } 111 const char* debugName() const override { return m_handle->debugName(); }
104 112
105 std::unique_ptr<WebDataConsumerHandle> m_handle; 113 std::unique_ptr<WebDataConsumerHandle> m_handle;
106 }; 114 };
107 115
108 } // namespace 116 } // namespace
109 117
110 std::unique_ptr<WebDataConsumerHandle> createWaitingDataConsumerHandle() 118 std::unique_ptr<WebDataConsumerHandle> createWaitingDataConsumerHandle()
111 { 119 {
112 return wrapUnique(new WaitingHandle); 120 return wrapUnique(new WaitingHandle);
113 } 121 }
114 122
115 std::unique_ptr<WebDataConsumerHandle> createDoneDataConsumerHandle() 123 std::unique_ptr<WebDataConsumerHandle> createDoneDataConsumerHandle()
116 { 124 {
117 return wrapUnique(new DoneHandle); 125 return wrapUnique(new DoneHandle);
118 } 126 }
119 127
120 std::unique_ptr<WebDataConsumerHandle> createUnexpectedErrorDataConsumerHandle() 128 std::unique_ptr<WebDataConsumerHandle> createUnexpectedErrorDataConsumerHandle()
121 { 129 {
122 return wrapUnique(new UnexpectedErrorHandle); 130 return wrapUnique(new UnexpectedErrorHandle);
123 } 131 }
124 132
125 std::unique_ptr<FetchDataConsumerHandle> createFetchDataConsumerHandleFromWebHan dle(std::unique_ptr<WebDataConsumerHandle> handle) 133 std::unique_ptr<FetchDataConsumerHandle> createFetchDataConsumerHandleFromWebHan dle(std::unique_ptr<WebDataConsumerHandle> handle)
126 { 134 {
127 return wrapUnique(new WebToFetchDataConsumerHandleAdapter(std::move(handle)) ); 135 return wrapUnique(new WebToFetchDataConsumerHandleAdapter(std::move(handle)) );
128 } 136 }
129 137
130 NotifyOnReaderCreationHelper::NotifyOnReaderCreationHelper(WebDataConsumerHandle ::Client* client) 138 NotifyOnReaderCreationHelper::NotifyOnReaderCreationHelper(WebDataConsumerHandle ::Client* client, WebTaskRunner* taskRunner)
131 : m_factory(this) 139 : m_factory(this)
132 { 140 {
141 DCHECK(taskRunner->runsTasksOnCurrentThread());
133 if (!client) 142 if (!client)
134 return; 143 return;
135 // Note we don't need thread safety here because this object is 144 // Note we don't need thread safety here because this object is
136 // bound to the current thread. 145 // bound to the current thread.
137 Platform::current()->currentThread()->getWebTaskRunner()->postTask(BLINK_FRO M_HERE, WTF::bind(&NotifyOnReaderCreationHelper::notify, m_factory.createWeakPtr (), WTF::unretained(client))); 146 taskRunner->postTask(BLINK_FROM_HERE, WTF::bind(&NotifyOnReaderCreationHelpe r::notify, m_factory.createWeakPtr(), WTF::unretained(client)));
138 } 147 }
139 148
140 void NotifyOnReaderCreationHelper::notify(WebDataConsumerHandle::Client* client) 149 void NotifyOnReaderCreationHelper::notify(WebDataConsumerHandle::Client* client)
141 { 150 {
142 // |client| dereference is safe here because: 151 // |client| dereference is safe here because:
143 // - |this| is owned by a reader, 152 // - |this| is owned by a reader,
144 // so the reader outlives |this|, and 153 // so the reader outlives |this|, and
145 // - |client| is the client of the reader, so |client| outlives the reader 154 // - |client| is the client of the reader, so |client| outlives the reader
146 // (guaranteed by the user of the reader), 155 // (guaranteed by the user of the reader),
147 // and therefore |client| outlives |this|. 156 // and therefore |client| outlives |this|.
148 client->didGetReadable(); 157 client->didGetReadable();
149 } 158 }
150 159
151 } // namespace blink 160 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698