tools/flags/SkCommonFlagsConfig.cpp - Issue 2177193004: Always supply a color space (sRGB for now) with F16

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/flags/SkCommonFlagsConfig.cpp

Issue 2177193004: Always supply a color space (sRGB for now) with F16 (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Fix uploading of F16 textures with color spaces Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/flags/SkCommonFlagsConfig.cpp

diff --git a/tools/flags/SkCommonFlagsConfig.cpp b/tools/flags/SkCommonFlagsConfig.cpp

index d5c7a1d5bf2b7af10f02bff596d64e8cef6509b5..4a4684ff5c77cdc629779ec5d535f6bf6475ddd9 100644

--- a/tools/flags/SkCommonFlagsConfig.cpp

+++ b/tools/flags/SkCommonFlagsConfig.cpp

@@ -284,7 +284,7 @@ static bool parse_option_gpu_color(const SkString& value,

}

if (value.equals("f16")) {

*outColorType = kRGBA_F16_SkColorType;

- *outColorSpace = nullptr;

+ *outColorSpace = SkColorSpace::NewNamed(SkColorSpace::kSRGB_Named);

return true;

}

if (value.equals("srgb")) {

« no previous file with comments | « tests/TestConfigParsing.cpp ('k') | tools/skiaserve/Request.cpp » ('j') | no next file with comments »