Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2177193002: [Turbofan] Too-strong CHECK during optimization. (Closed)

Created:
4 years, 4 months ago by mvstanton
Modified:
4 years, 4 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Turbofan] IsUseLessGeneral shouldn't consider machine representation. BUG=chromium:630952 Committed: https://crrev.com/480f155ed65d23310db92cd65470a9a68d5f13bd Cr-Commit-Position: refs/heads/master@{#38014}

Patch Set 1 #

Patch Set 2 : Fix nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -51 lines) Patch
M src/compiler/simplified-lowering.cc View 2 chunks +1 line, -51 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-630952.js View 1 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
mvstanton
Hi Benedikt, here is the fix we discussed, thx! --Mike
4 years, 4 months ago (2016-07-25 10:49:21 UTC) #4
Benedikt Meurer
lgtm
4 years, 4 months ago (2016-07-25 10:50:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2177193002/20001
4 years, 4 months ago (2016-07-25 11:28:40 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-25 11:59:34 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-07-25 12:01:59 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/480f155ed65d23310db92cd65470a9a68d5f13bd
Cr-Commit-Position: refs/heads/master@{#38014}

Powered by Google App Engine
This is Rietveld 408576698