Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: test/mjsunit/stack-traces.js

Issue 2177183002: Make stack property collected by captureStackTrace non-enumerable and -writable. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/builtins/builtins-error.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2009 the V8 project authors. All rights reserved. 1 // Copyright 2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 363 matching lines...) Expand 10 before | Expand all | Expand 10 after
374 assertEquals("abc", error.stack); 374 assertEquals("abc", error.stack);
375 375
376 error = new Error(); 376 error = new Error();
377 error.__defineGetter__("name", function() { delete error.stack; }); 377 error.__defineGetter__("name", function() { delete error.stack; });
378 assertEquals(undefined, error.stack); 378 assertEquals(undefined, error.stack);
379 379
380 // Check that repeated trace collection does not crash. 380 // Check that repeated trace collection does not crash.
381 error = new Error(); 381 error = new Error();
382 Error.captureStackTrace(error); 382 Error.captureStackTrace(error);
383 383
384 // Check property descriptor.
385 var o = {};
386 Error.captureStackTrace(o);
387 assertEquals([], Object.keys(o));
388 var desc = Object.getOwnPropertyDescriptor(o, "stack");
389 assertFalse(desc.writable);
390 assertFalse(desc.enumerable);
391 assertTrue(desc.configurable);
392
384 // Check that exceptions thrown within prepareStackTrace throws an exception. 393 // Check that exceptions thrown within prepareStackTrace throws an exception.
385 Error.prepareStackTrace = function(e, frames) { throw 42; } 394 Error.prepareStackTrace = function(e, frames) { throw 42; }
386 395
387 var x = {} 396 var x = {}
388 assertThrows(() => Error.captureStackTrace(x)); 397 assertThrows(() => Error.captureStackTrace(x));
OLDNEW
« no previous file with comments | « src/builtins/builtins-error.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698