Issue 2177183002: Make stack property collected by captureStackTrace non-enumerable and -writable.

Issue 2177183002: Make stack property collected by captureStackTrace non-enumerable and -writable. (Closed)

Created:
4 years, 5 months ago by Yang

Modified:
4 years, 4 months ago

Reviewers:
ofrobots, jgruber

CC:
v8-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Make stack property collected by captureStackTrace non-enumerable and -writable. TBR=jgruber@chromium.org Committed: https://crrev.com/02503b080fbda2d8a72581a4669ea400d5322670 Cr-Commit-Position: refs/heads/master@{#38005}

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -5 lines)			Patch
	M	src/builtins/builtins-error.cc	View		1 chunk	+9 lines, -5 lines	0 comments	Download
	M	test/mjsunit/stack-traces.js	View		1 chunk	+9 lines, -0 lines	0 comments	Download

Total messages: 10 (5 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2177183002/1

4 years, 5 months ago (2016-07-25 09:36:53 UTC) #5

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/02503b080fbda2d8a72581a4669ea400d5322670 Cr-Commit-Position: refs/heads/master@{#38005}

4 years, 5 months ago (2016-07-25 10:04:24 UTC) #9

Message was sent while issue was closed.

lgtm, thanks.