Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2177173002: Convert editing/inserting/insert-tab-00[1-4].html to use w3c test harness (Closed)

Created:
4 years, 5 months ago by yosin_UTC9
Modified:
4 years, 5 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert editing/inserting/insert-tab-00[1-4].html to use w3c test harness This patch converts "editing/inserting/insert-tab-00[1-4].html" to use w3c test harness and consolidates into "insert_tab.html" to simplify test case for ease of maintenance. This patch is a preparation of getting rid of grammar checking feature. Committed: https://crrev.com/7567c771193d8c60992f0ab2aae5ae7698eb89b1 Cr-Commit-Position: refs/heads/master@{#407671}

Patch Set 1 : 2016-07-25T18:11:29 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -371 lines) Patch
D third_party/WebKit/LayoutTests/editing/inserting/insert-tab-001.html View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/inserting/insert-tab-002.html View 1 chunk +0 lines, -35 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/inserting/insert-tab-003.html View 1 chunk +0 lines, -35 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/inserting/insert-tab-004.html View 1 chunk +0 lines, -34 lines 0 comments Download
A third_party/WebKit/LayoutTests/editing/inserting/insert_tab.html View 1 chunk +78 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-tab-001-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-tab-001-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-tab-002-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-tab-002-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-tab-003-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-tab-003-expected.txt View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-tab-004-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-tab-004-expected.txt View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-tab-001-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-tab-001-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-tab-002-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-tab-002-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-tab-003-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-tab-003-expected.txt View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-tab-004-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-tab-004-expected.txt View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-tab-001-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-tab-001-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-tab-002-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-tab-002-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-tab-003-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-tab-003-expected.txt View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-tab-004-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-tab-004-expected.txt View 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
yosin_UTC9
PTAL
4 years, 5 months ago (2016-07-25 09:38:14 UTC) #5
Xiaocheng
lgtm
4 years, 5 months ago (2016-07-25 09:53:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2177173002/1
4 years, 5 months ago (2016-07-26 01:15:19 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-26 01:20:40 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-26 01:22:32 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7567c771193d8c60992f0ab2aae5ae7698eb89b1
Cr-Commit-Position: refs/heads/master@{#407671}

Powered by Google App Engine
This is Rietveld 408576698