Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 2177163003: Add null-check to ShapeResult::fallbackFonts (Closed)

Created:
4 years, 5 months ago by eae
Modified:
4 years, 5 months ago
Reviewers:
pdr.
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, jbroman, Justin Novosad, Rik, f(malita), blink-reviews, Stephen Chennney, ajuma+watch_chromium.org, danakj+watch_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add null-check to ShapeResult::fallbackFonts Add a null check for m_runs[i]->m_fontData in ShapeResult::fallbackFonts to ensure that isTextOrientationFallbackOf is only called when it's set. TBR=pdr@chromium.org BUG=629005 Committed: https://crrev.com/63402c5b51408d48710846f739fe07b2d1b19d1e Cr-Commit-Position: refs/heads/master@{#407633}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/Source/platform/fonts/shaping/ShapeResult.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2177163003/1
4 years, 5 months ago (2016-07-25 20:10:20 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-25 23:36:54 UTC) #3
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 23:39:55 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/63402c5b51408d48710846f739fe07b2d1b19d1e
Cr-Commit-Position: refs/heads/master@{#407633}

Powered by Google App Engine
This is Rietveld 408576698