third_party/WebKit/Source/core/dom/StyleEngine.cpp - Issue 2177163002: Allow <link rel=stylesheet> in a connected shadow tree

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/StyleEngine.cpp

Issue 2177163002: Allow <link rel=stylesheet> in a connected shadow tree (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: wip Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/shadow-dom/link-element.html ('K') | « third_party/WebKit/Source/core/dom/ShadowTreeStyleSheetCollection.cpp ('k') | third_party/WebKit/Source/core/html/HTMLLinkElement.cpp » ('j') | third_party/WebKit/Source/core/html/HTMLLinkElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/StyleEngine.cpp

diff --git a/third_party/WebKit/Source/core/dom/StyleEngine.cpp b/third_party/WebKit/Source/core/dom/StyleEngine.cpp

index f601b79e16e7396e7a76ba240211c21fa8863a9b..fdc4487850acbeeffa9fa270373aa76ecaff96d1 100644

--- a/third_party/WebKit/Source/core/dom/StyleEngine.cpp

+++ b/third_party/WebKit/Source/core/dom/StyleEngine.cpp

@@ -191,8 +191,8 @@ void StyleEngine::addStyleSheetCandidateNode(Node* node)

if (!node->isConnected() || document().isDetached())

return;

- TreeScope& treeScope = isStyleElement(*node) ? node->treeScope() : *m_document;

DCHECK(!isXSLStyleSheet(*node));

+ TreeScope& treeScope = node->treeScope();

TreeScopeStyleSheetCollection* collection = ensureStyleSheetCollectionFor(treeScope);

DCHECK(collection);

collection->addStyleSheetCandidateNode(node);