Issue 21771002: Generate grokdump constants with 'make grokdump' now.

Issue 21771002: Generate grokdump constants with 'make grokdump' now. (Closed)

Created:
7 years, 4 months ago by Michael Starzinger

Modified:
7 years, 4 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Generate grokdump constants with 'make grokdump' now. R=svenpanne@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16022

Patch Set 2 : Addressed comments by Sven Panne and fixed x64 build. #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+342 lines, -262 lines)			Patch
M	Makefile	View	1	3 chunks	+8 lines, -1 line	0 comments	Download
M	src/d8.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/d8.cc	View	1	3 chunks	+72 lines, -0 lines	0 comments	Download
M	tools/grokdump.py	View		3 chunks	+6 lines, -256 lines	0 comments	Download
A	tools/v8heapconst.py	View		1 chunk	+252 lines, -0 lines	0 comments	Download
A +	tools/v8heapconst.py.tmpl	View		1 chunk	+2 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

LGTM with a nit https://codereview.chromium.org/21771002/diff/1/Makefile File Makefile (right): https://codereview.chromium.org/21771002/diff/1/Makefile#newcode408 Makefile:408: @cat $(DUMP_FILE).tmpl >$(DUMP_FILE) Nit: A ...

7 years, 4 months ago (2013-08-02 08:51:02 UTC) #2

Michael Starzinger

Comments addressed. Fixed x64 build. Landing. https://codereview.chromium.org/21771002/diff/1/Makefile File Makefile (right): https://codereview.chromium.org/21771002/diff/1/Makefile#newcode408 Makefile:408: @cat $(DUMP_FILE).tmpl >$(DUMP_FILE) ...

7 years, 4 months ago (2013-08-02 08:59:31 UTC) #3

Michael Starzinger

7 years, 4 months ago (2013-08-02 09:02:11 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r16022 (presubmit successful).

Expand Messages | Collapse Messages