Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2177073002:
remove unneeded call to deprecated method (Closed)
Descriptionremove unneeded call to deprecated method
In this context, the bitmap is explicitly allocated, so it must be writable.
BUG=skia:4328
Committed: https://crrev.com/1bd8b753f0fd9d5bd1146163b2bda3c3b3082ceb
Cr-Commit-Position: refs/heads/master@{#407455}
Patch Set 1 #
Messages
Total messages: 23 (13 generated)
Description was changed from ========== remove unneeded call to deprecated method BUG=skia:4328 ========== to ========== remove unneeded call to deprecated method In this context, the bitmap is explicitly allocated, so it must be writable. BUG=skia:4328 ==========
The CQ bit was checked by reed@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
reed@google.com changed reviewers: + fmalita@chromium.org
reed@google.com changed reviewers: + tomhudson@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by fmalita@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
reed@google.com changed reviewers: + dcheng@chromium.org, rsesek@chromium.org, tsepez@chromium.org
need SECURITY_OWNERS review
rs lgtm
The CQ bit was checked by reed@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== remove unneeded call to deprecated method In this context, the bitmap is explicitly allocated, so it must be writable. BUG=skia:4328 ========== to ========== remove unneeded call to deprecated method In this context, the bitmap is explicitly allocated, so it must be writable. BUG=skia:4328 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== remove unneeded call to deprecated method In this context, the bitmap is explicitly allocated, so it must be writable. BUG=skia:4328 ========== to ========== remove unneeded call to deprecated method In this context, the bitmap is explicitly allocated, so it must be writable. BUG=skia:4328 Committed: https://crrev.com/1bd8b753f0fd9d5bd1146163b2bda3c3b3082ceb Cr-Commit-Position: refs/heads/master@{#407455} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/1bd8b753f0fd9d5bd1146163b2bda3c3b3082ceb Cr-Commit-Position: refs/heads/master@{#407455} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
