Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2177003002: Convert video-play* http tests to testharness.js (Closed)

Created:
4 years, 5 months ago by Srirama
Modified:
4 years, 5 months ago
Reviewers:
fs, foolip
CC:
blink-reviews, chromium-reviews, feature-media-reviews_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert video-play* http tests to testharness.js Cleaning up video-play* http tests to use testharness.js instead of video-test.js. This will enable to upstream these tests to web-platform-tests. BUG=588956 Committed: https://crrev.com/9cfb142f9ddf22dc649be7da2af8298204340e3f Cr-Commit-Position: refs/heads/master@{#407369}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -57 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/media/video-play-progress.html View 1 chunk +16 lines, -26 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/media/video-play-progress-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/media/video-play-stall-before-meta-data.html View 2 chunks +15 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/media/video-play-stall-before-meta-data-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Srirama
PTAL
4 years, 5 months ago (2016-07-23 12:28:33 UTC) #3
fs
lgtm
4 years, 5 months ago (2016-07-23 17:13:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2177003002/1
4 years, 5 months ago (2016-07-23 17:17:32 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-23 18:18:08 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-23 18:19:30 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9cfb142f9ddf22dc649be7da2af8298204340e3f
Cr-Commit-Position: refs/heads/master@{#407369}

Powered by Google App Engine
This is Rietveld 408576698