Tiny: Fix crash in FileSelectHelper::CheckDownloadRequestWithSafeBrowsing

Fix crash in FileSelectHelper::CheckDownloadRequestWithSafeBrowsing

Use profile_ directly instead of getting profile info from web_contents_, since web_contents_ might be NULL.

BUG=630778

[Jialiu Lin, 2016-07-23 00:24:55]

The CQ bit was checked by jialiul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-23 00:25:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jialiu Lin, 2016-07-23 00:28:55]

Description was changed from

==========
Fix crash in FileSelectHelper::CheckDownloadRequestWithSafeBrowsing

Add validity checking of current profile before send it to check
safe browsing.

BUG=630778
==========

to

==========
Fix crash in FileSelectHelper::CheckDownloadRequestWithSafeBrowsing

Add validity checking of current profile before check with safe
browsing.

BUG=630778
==========

[commit-bot: I haz the power, 2016-07-23 01:38:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-23 01:38:08]

Dry run: This issue passed the CQ dry run.

[Jialiu Lin, 2016-07-23 01:40:15]

jialiul@chromium.org changed reviewers:
+ jochen@chromium.org

[Jialiu Lin, 2016-07-23 01:40:16]

Hi jochen@, 
Could you take a look at this small fix? Thanks!

[jochen (gone - plz use gerrit), 2016-07-25 16:19:31]

could you add a test for this please?

[Jialiu Lin, 2016-07-25 18:51:16]

Hi jochen@,
I really want to add a test, though in this case, I don't know what's the best
way to do that. In general, file_select_helper class has already had a low test
coverage before any of my changes. I know this is not a valid excuse, which I
feel really sorry for it too...But can I defer this task until asanka@ is back?
(he is OOO till Aug) He's more familiar with PPAPI file chooser.

[Jialiu Lin, 2016-07-25 19:04:24]

Description was changed from

==========
Fix crash in FileSelectHelper::CheckDownloadRequestWithSafeBrowsing

Add validity checking of current profile before check with safe
browsing.

BUG=630778
==========

to

==========
Fix crash in FileSelectHelper::CheckDownloadRequestWithSafeBrowsing

Use profile_ directly instead of getting profile info from web_contents_, since
web_contents_ might be NULL.

BUG=630778
==========

[Jialiu Lin, 2016-07-26 16:43:58]

Bug filed for adding more tests of FileSelectHelper. 
https://bugs.chromium.org/p/chromium/issues/detail?id=631503

[jochen (gone - plz use gerrit), 2016-07-27 07:38:21]

thanks for filing the bug. I'd suggest to wait for asanka@ to come back, so we
can land the fix together with the test.

[Jialiu Lin, 2016-07-27 16:32:09]

On 2016/07/27 07:38:21, jochen wrote:
> thanks for filing the bug. I'd suggest to wait for asanka@ to come back, so we
> can land the fix together with the test.

Make sense. Thanks, jochen@.  
Since the crashing rate on canary is pretty high, I'm going to revert my
previous CL that caused this.