Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issue 2176883002: Don't specify the SHA1PRNG algorithm. (Closed)

Created:
4 years, 5 months ago by palmer
Modified:
4 years, 5 months ago
Reviewers:
Ted C, nyquist, Robert Sesek
CC:
chromium-reviews, darin-cc_chromium.org, dominickn+watch_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't specify the SHA1PRNG algorithm. Use the default SecureRandom constructor instead. Per http://android-developers.blogspot.com/2016/06/security-crypto-provider-deprecated-in.html, SHA1PRNG is going away. BUG=none Committed: https://crrev.com/e6273b7b6c3911c490d0f4355c9c61e27f647b68 Cr-Commit-Position: refs/heads/master@{#407641}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/externalnav/IntentWithGesturesHandler.java View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappAuthenticator.java View 1 chunk +1 line, -1 line 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/crypto/CipherFactory.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (8 generated)
palmer
4 years, 5 months ago (2016-07-22 22:20:06 UTC) #2
palmer
I wonder if rsesek might be interested, too.
4 years, 5 months ago (2016-07-22 22:20:50 UTC) #4
Ted C
they mention it is deprecated in N, should we only be doing this on N+ ...
4 years, 5 months ago (2016-07-22 22:29:41 UTC) #5
palmer
> they mention it is deprecated in N, should we only be doing this on ...
4 years, 5 months ago (2016-07-22 22:40:24 UTC) #8
Robert Sesek
LGTM
4 years, 5 months ago (2016-07-25 22:32:00 UTC) #11
Ted C
lgtm for me then too :-)
4 years, 5 months ago (2016-07-25 22:38:08 UTC) #12
nyquist
lgtm me three
4 years, 5 months ago (2016-07-25 23:02:19 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2176883002/1
4 years, 5 months ago (2016-07-25 23:04:00 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-26 00:06:03 UTC) #16
commit-bot: I haz the power
4 years, 5 months ago (2016-07-26 00:09:16 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e6273b7b6c3911c490d0f4355c9c61e27f647b68
Cr-Commit-Position: refs/heads/master@{#407641}

Powered by Google App Engine
This is Rietveld 408576698