Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 217683002: Add documentation about how to debug non-stable PNaCl pexes in Pepper 35. (Closed)

Created:
6 years, 9 months ago by jvoung (off chromium)
Modified:
6 years, 9 months ago
Reviewers:
bradnelson, binji, Sam Clegg
CC:
chromium-reviews, native-client-reviews_googlegroups.com, binji, Sam Clegg
Visibility:
Public.

Description

Add documentation about how to debug non-stable PNaCl pexes in Pepper 35. Document the "remote get nexe <path>" and "remote get irt <other-path>" commands. Also document the --nacl-debug-mask=<pattern_set> flag. BUG=http://code.google.com/p/nativeclient/issues/detail?id=3765 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260303

Patch Set 1 #

Total comments: 5

Patch Set 2 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+261 lines, -65 lines) Patch
M native_client_sdk/doc_generated/devguide/devcycle/debugging.html View 1 6 chunks +126 lines, -40 lines 0 comments Download
M native_client_sdk/doc_generated/reference/nacl-manifest-format.html View 2 chunks +13 lines, -1 line 0 comments Download
M native_client_sdk/src/doc/devguide/devcycle/debugging.rst View 1 5 chunks +122 lines, -24 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jvoung (off chromium)
https://codereview.chromium.org/217683002/diff/1/native_client_sdk/src/doc/devguide/devcycle/debugging.rst File native_client_sdk/src/doc/devguide/devcycle/debugging.rst (right): https://codereview.chromium.org/217683002/diff/1/native_client_sdk/src/doc/devguide/devcycle/debugging.rst#newcode274 native_client_sdk/src/doc/devguide/devcycle/debugging.rst:274: Debugging PNaCl pexes (with older Pepper toolchains) My though ...
6 years, 9 months ago (2014-03-28 22:05:42 UTC) #1
Sam Clegg
lgtm https://codereview.chromium.org/217683002/diff/1/native_client_sdk/src/doc/devguide/devcycle/debugging.rst File native_client_sdk/src/doc/devguide/devcycle/debugging.rst (right): https://codereview.chromium.org/217683002/diff/1/native_client_sdk/src/doc/devguide/devcycle/debugging.rst#newcode398 native_client_sdk/src/doc/devguide/devcycle/debugging.rst:398: This helps accidentally debugging other PNaCl applications if ...
6 years, 9 months ago (2014-03-28 22:18:29 UTC) #2
jvoung (off chromium)
https://codereview.chromium.org/217683002/diff/1/native_client_sdk/src/doc/devguide/devcycle/debugging.rst File native_client_sdk/src/doc/devguide/devcycle/debugging.rst (right): https://codereview.chromium.org/217683002/diff/1/native_client_sdk/src/doc/devguide/devcycle/debugging.rst#newcode398 native_client_sdk/src/doc/devguide/devcycle/debugging.rst:398: This helps accidentally debugging other PNaCl applications if you ...
6 years, 9 months ago (2014-03-28 22:39:33 UTC) #3
jvoung (off chromium)
The CQ bit was checked by jvoung@chromium.org
6 years, 9 months ago (2014-03-28 23:02:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jvoung@chromium.org/217683002/20001
6 years, 9 months ago (2014-03-28 23:03:33 UTC) #5
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 23:46:11 UTC) #6
Message was sent while issue was closed.
Change committed as 260303

Powered by Google App Engine
This is Rietveld 408576698