Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2176823002: Revert the patch that has disabled Panels for M53 (https://codereview.chromium.org/2083113002) (Closed)

Created:
4 years, 5 months ago by Dmitry Titov
Modified:
4 years, 5 months ago
Reviewers:
Lei Zhang, jianli
CC:
chromium-reviews, jennb, jianli, Dmitry Titov, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert the patch that has disabled Panels for M53 (https://codereview.chromium.org/2083113002) The current plan is to remove the code for M54 but keep the Panels enabled for M53 to provide more time for transition. BUG=571511 Committed: https://crrev.com/af86f4caef16dc6a12edbb8305ba2149ee763cc9 Cr-Commit-Position: refs/heads/master@{#407262}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -7 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_manager.cc View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Dmitry Titov
Revert of previous patch due to LR deciding not to disable panels in M53. jianli@: ...
4 years, 5 months ago (2016-07-22 20:01:29 UTC) #2
jianli
lgtm
4 years, 5 months ago (2016-07-22 20:05:39 UTC) #5
Lei Zhang
lgtm
4 years, 5 months ago (2016-07-22 20:30:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2176823002/1
4 years, 5 months ago (2016-07-22 20:37:28 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 21:11:46 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 21:13:01 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/af86f4caef16dc6a12edbb8305ba2149ee763cc9
Cr-Commit-Position: refs/heads/master@{#407262}

Powered by Google App Engine
This is Rietveld 408576698