mash: Migrate ShelfTooltipManager to wm common types.

ash/shelf/shelf_view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_SHELF_SHELF_VIEW_H_
 #define ASH_SHELF_SHELF_VIEW_H_
 
 #include <memory>
 #include <string>
 #include <utility>
@@ skipping 57 matching lines @@
                              public views::BoundsAnimatorObserver,
                              public app_list::ApplicationDragAndDropHost {
  public:
   ShelfView(ShelfModel* model,
             ShelfDelegate* delegate,
             WmShelf* wm_shelf,
             Shelf* shelf);
   ~ShelfView() override;
 
   Shelf* shelf() const { return shelf_; }
+  WmShelf* wm_shelf() const { return wm_shelf_; }

[James Cook, 2016/07/22 23:48:21]

optional: This is OK, but what do you think of passing WmShelf into the
ShelfTooltipManager constructor instead? I've been trying to dependency-inject
things in the shelf code because I think it makes it a little more obvious about
what needs to be constructed before what else. I don't feel strongly, though.

[msw, 2016/07/25 22:56:44]

The WmShelf is injected into ShelfView via ctor, seems okay to use that value
from an 'internal' object owned by ShelfView (like tooltip manager), but I don't
feel too strongly, and would gladly change it.

   ShelfModel* model() const { return model_; }
 
   void Init();
 
   void OnShelfAlignmentChanged();
   void SchedulePaintForAllButtons();
 
   // Returns the ideal bounds of the specified item, or an empty rect if id
   // isn't know. If the item is in an overflow shelf, the overflow icon location
   // will be returned.
@@ skipping 378 matching lines @@
 
   // Tracks UMA metrics based on shelf button press actions.
   ShelfButtonPressedMetricTracker shelf_button_pressed_metric_tracker_;
 
   DISALLOW_COPY_AND_ASSIGN(ShelfView);
 };
 
 }  // namespace ash
 
 #endif  // ASH_SHELF_SHELF_VIEW_H_