Issue 2176803003: Add new atomic operations and use them in two places.

Issue 2176803003: Add new atomic operations and use them in two places. (Closed)

Created:
4 years, 5 months ago by Florian Schneider

Modified:
4 years, 5 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Add new atomic operations and use them in two places. 1. Setting the IC data array. This may have caused corrupt IC data seen by the background compiler when cloning IC data. 2. Reading the thread_interrupt_disabled_ flag. This was reported as a race with TSAN. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/27863288dbff2f008255a89854b73e2ab698c9f1

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+73 lines, -3 lines)			Patch
M	runtime/vm/atomic.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/atomic_android.h	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	runtime/vm/atomic_fuchsia.h	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	runtime/vm/atomic_linux.h	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	runtime/vm/atomic_macos.h	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	runtime/vm/atomic_win.h	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	runtime/vm/object.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/object.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/os_thread.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/raw_object.h	View	1 chunk	+12 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

Florian Schneider

4 years, 5 months ago (2016-07-22 22:41:00 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
27863288dbff2f008255a89854b73e2ab698c9f1 (presubmit successful).